Fix the release workflow broken by #36 - #38
Merged
Merged
Conversation
Adding the NRW step swallowed the "- name: Build fat jar" line of the step after it, so that step's run: landed in the NRW step. GitHub rejects a step with two run: keys, which failed the v5.4.0 release before it started. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KLR5H7eqDSncYYkosKf8r5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#36 left
.github/workflows/release.ymlinvalid:(Line: 60, Col: 9): 'run' is already defined. Adding the "Build NRW jar" step swallowed the- name: Build fat jarline of the step after it, so that step'srun:ended up inside the NRW step.Because the file is invalid, the release run for v5.4.0 (the #37 merge) failed before any job started. Nothing was published: the latest release is still v5.3.1, both on GitHub and on Maven Central.
This PR restores the missing line. It changes nothing else.
Testing
actionlintreproduces the error onmainand reports nothing on this branch, for every workflow file.I ran the workflow's build steps locally on this branch, at version 5.4.0:
mvn -B clean package -Pall,nrwdist/mvn -B clean package -Pall -DskipTestsThe release would upload
scratch-5.4.0.jar,-all,-sourcesand-javadocfromtarget/, andscratch-5.4.0-nrw-all.jarand-nrw-sources.jarfromdist/.Merging this publishes v5.4.0
release.ymlruns on every PR merged intomain, andpom.xmlis already at 5.4.0. So merging this PR deploys v5.4.0 to Maven Central and creates the GitHub release, with this PR's description as the release notes. The GitHub release can be edited afterwards; the Maven Central upload can't be taken back.No changeset, since this only fixes CI.
🤖 Generated with Claude Code
https://claude.ai/code/session_01KLR5H7eqDSncYYkosKf8r5
Generated by Claude Code