Skip to content

Add node26 template - #166

Open
welteki wants to merge 1 commit into
openfaas:masterfrom
welteki:add-node26-template
Open

welteki wants to merge 1 commit into
openfaas:masterfrom
welteki:add-node26-template

Conversation

@welteki

@welteki welteki commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Description

Add the node26 template and make it the recommended node template.

Drop the recommended flag from the node25 template as it has reached
end-of-life and is no longer supported upstream.

Motivation

Node.js 26 is the latest LTS version.

How has this been tested

Verified the output of faas-cli template store list:

faas-cli template store list --url https://raw.githubusercontent.com/welteki/store/add-node26-template/templates.json

NAME                     RECOMMENDED DESCRIPTION        SOURCE
bash-streaming           [x]         openfaas-incubator Bash Streaming template
dockerfile               [x]         openfaas           Classic Dockerfile template
dotnet8-csharp           [x]         openfaas           C# template using WebApplication
golang-middleware        [x]         openfaas           HTTP middleware interface in Go
golang-middleware-inproc [x]         openfaas           Fastest template for Go, suitable for beta testing.
java11-vert-x            [x]         openfaas           Java 11 Vert.x template
node22                   [x]         openfaas           HTTP-based Node 22 template
node24                   [x]         openfaas           HTTP-based Node 24 template
node26                   [x]         openfaas           HTTP-based Node 26 template
php8                     [x]         openfaas           Classic PHP 8 template
python3-http             [x]         openfaas           Python 3 with Flask and HTTP
python3-http-debian      [x]         openfaas           Python 3 with Flask and HTTP based on Debian
ruby-http                [x]         openfaas           Ruby 3.3.6 HTTP template
cobol                    [ ]         devries            COBOL Template
perl-alpine              [ ]         tmiklas            Perl language template based on Alpine image
powershell-http-template [ ]         openfaas-incubator Powershell Core HTTP Ubuntu:16.04 template
powershell-template      [ ]         openfaas-incubator Powershell Core Ubuntu:16.04 template
quarkus-native           [ ]         pmlopes            Quarkus.io native image template
rust                     [ ]         openfaas-incubator Community Rust template
rust-http                [ ]         openfaas-incubator Community Rust template with HTTP bindings
bun-express              [ ]         openfaas           HTTP-based template using bun
golang-http              [ ]         openfaas           Request/response style HTTP template
java11                   [ ]         openfaas           Java 11 template
java17                   [ ]         openfaas           Java 17 template
node20                   [ ]         openfaas           HTTP-based Node 20 template
node25                   [ ]         openfaas           HTTP-based Node 25 template
php7                     [ ]         openfaas           Classic PHP 7 template
puppeteer-nodelts        [ ]         alexellis          A puppeteer template for headless Chrome

Add the new Node 26 template from openfaas/templates to the store
listing, keeping node26 as recommended. Remove the recommended flag
from the node25 template as it has reached end-of-life and is no
longer supported upstream.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
@reviewfn

reviewfn Bot commented Sep 28, 2026

Copy link
Copy Markdown

AI Pull Request Overview

Disclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification.

Summary

  • Adds node26 to the OpenFaaS template store metadata.
  • Marks node26 as a recommended official NodeJS template.
  • Keeps node25 listed but removes its recommended status.
  • The scoped change is limited to template index metadata.
  • No blocking correctness issues were found in the reviewed diff.

Approval rating (1-10)

9/10. The metadata change is small, consistent with adjacent entries, and matches the stated migration from node25 to node26.

Summary per file

Summary per file
File path Summary
templates.json Adds recommended node26 entry and demotes node25.

Overall Assessment

The pull request cleanly updates the store index to prefer the new Node 26 template while preserving Node 25 as a non-recommended option. The changed entry follows the existing schema and placement used for nearby Node templates. I did not find a specific defect, regression, or migration risk in the scoped diff.

Detailed Review

Detailed Review

No blocking findings.

AI agent details.

Agent processing time: 52.315s
Environment preparation time: 3.152s
Total time from webhook: 58.534s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant