Repository navigation
Conversation
Add the new Node 26 template from openfaas/templates to the store listing, keeping node26 as recommended. Remove the recommended flag from the node25 template as it has reached end-of-life and is no longer supported upstream. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
AI Pull Request OverviewDisclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification. Summary
Approval rating (1-10)9/10. The metadata change is small, consistent with adjacent entries, and matches the stated migration from Summary per fileSummary per file
Overall AssessmentThe pull request cleanly updates the store index to prefer the new Node 26 template while preserving Node 25 as a non-recommended option. The changed entry follows the existing schema and placement used for nearby Node templates. I did not find a specific defect, regression, or migration risk in the scoped diff. Detailed ReviewDetailed ReviewNo blocking findings. AI agent details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the node26 template and make it the recommended node template.
Drop the recommended flag from the node25 template as it has reached
end-of-life and is no longer supported upstream.
Motivation
Node.js 26 is the latest LTS version.
How has this been tested
Verified the output of
faas-cli template store list: