You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Style Interference & Style Isolation issues when embedding component #580
There were style leaks from this component to the parent application (the fix was already applied). However, there is still style pollution from the parent application affecting this component.
This component should be reusable everywhere:
Styles from this component shouldn't affect the parent application that uses it.
Styles from the parent application shouldn't affect this component.
Note: While we have previously resolved style leaks, we should consider moving to Shadow DOM (e.g., via Vue's defineCustomElement) as a robust, future-proof solution to permanently address both pollution and leakage. If we adopt Shadow DOM, we need to account for state management, event retargeting (composed: true), nested child-component CSS, and features such as <Teleport>.
@agarny, I found out that this is still on Vue 3.4 and the changes I have to make require Vue 3.5. On the other hand, SimulationVuer is already on 3.5. Is it ok to upgrade to 3.5?
Yes, we should upgrade to 3.5 at some point, so it looks like it's a good opportunity! Ok, I have actually created an issue for it (see issue #582) and addressed it (see PR #584). Note that to upgrade to Vue 3.5 is fine in itself. The issue I was telling you about was with PrimeVue, hence I have created another issue for it (see issue #583).
Activity
akhuoa commentedon Oct 21, 2026
@agarny, I found out that this is still on Vue
3.4and the changes I have to make require Vue3.5. On the other hand,SimulationVueris already on3.5. Is it ok to upgrade to3.5?agarny commentedon Oct 21, 2026
Yes, we should upgrade to 3.5 at some point, so it looks like it's a good opportunity! Ok, I have actually created an issue for it (see issue #582) and addressed it (see PR #584). Note that to upgrade to Vue 3.5 is fine in itself. The issue I was telling you about was with PrimeVue, hence I have created another issue for it (see issue #583).