Repository navigation
Conversation
Without a status function in its if, an all-done job is skipped (not failed) when a needed job fails or is cancelled, and a skipped required check counts as passing, also in the merge queue. Run all-done and all-done-validate unless the workflow is cancelled, and explicitly fail them if any of the needed jobs has failed or was cancelled (but not skipped). This is the same as done in runc. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
It only wraps the single actionlint job and, having no status function, is skipped (and passes as a required check) when actionlint fails. Drop it; actionlint itself can be required instead. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
With the merge queue enabled, all required checks must also pass for the merge group commit; a check that is not reported there makes the queue time out. Add the merge_group trigger to all the workflows that provide (or may provide) required checks. This includes review-policy: the reusable workflow from runc already handles merge_group (by doing nothing), but the triggers of a reusable workflow are ignored, so it must be added to the calling one. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare CI for enabling the merge queue, taking into account the issues we hit while doing the same in runc:
all-doneandall-done-validatefail when a needed job fails. Without a status function inif:, they are skipped (not failed) in this case, and a skipped required check counts as passing -- also in the merge queue. Same as in runc (#5609).all-done-actionlint, which has the same problem;actionlintitself can be required instead.merge_grouptrigger to all workflows providing required checks. This includesreview-policy: the reusable workflow from runc already does nothing formerge_group(#5563), but triggers of a reusable workflow are ignored, so the calling workflow must have it. Notereview-policy.ymlis a governance file.Once merged, the merge queue can be enabled in the repository settings, with the following required checks:
all-doneall-done-validateactionlintreview-policy / review-policy