fix display user name generation

[benderl]

user_name was always set to "Display-Intern", preventing creation of users for external openWB

[Copilot]

🟢 Approval recommended

The changes consistently fix external display-user creation without introducing unresolved issues.

0 open findings

What changed in this PR

Fixes display-user naming so external openWB instances receive IP-specific users while preserving the internal display account.

Changes:

• Generates Display-Intern only for localhost and Display-{IP} otherwise.
• Prevents removal of the internal display user.
• Safely handles failed user-existence lookups.

File	Description
packages/​helpermodules/​mosquitto_dynsec/​user_handler.py	Corrects display-user generation and removal safeguards.
packages/​helpermodules/​mosquitto_dynsec/​mosquitto_dynsec.py	Uses the corrected generation logic for required users.

🧠 Review effort: Balanced

---

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

[tpd-opitz]

Why this matters

A single module-level constant is enough if the special-case IP is only used in this file. It keeps the change small while still removing the magic value duplication. If you want to go one step further, INTERNAL_DISPLAY_USER = "Display-Intern" would also make the username special case clearer, but it’s optional.

[benderl]

@tpd-opitz
Habe es noch etwas bearbeitet. Jetzt ist die lokale IP nur noch in user_handler.py vorhanden.