Repository navigation
Hoist by_name() matching helpers out of template into importable code - #106
Merged
gefleury merged 2 commits intoOct 9, 2026
Merged
Conversation
This makes the code easier to test, and makes it reusable, specifically by fairgraph.
gefleury
approved these changes
Sep 14, 2026
| matches_name(name, query, match, case_sensitive, ignore_accents, ignore_separators) | ||
| for name in names | ||
| if name is not None | ||
| ) |
There was a problem hiding this comment.
test_agreement asserts nothing when found is None: should it also check that no instance's name-like properties/synonyms satisfy matches_name() for the query in that case?
Check both directions of the `by_name()`/`matches_name()` agreement. `test_agreement` only checked that every instance `by_name()` returned did match the query, so whenever `by_name()` found nothing the test asserted nothing at all: 8 of the 24 parameter combinations, namely every one with `ignore_accents=False` and `match` of "equals" or "contains". It now builds the expected list independently from `instances()` and asserts equality of sorted lists, so an instance that should have been found but wasn't is caught too, and an empty result is required to be `None` rather than an empty list.
gefleury
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the code easier to test, and makes it reusable, specifically by fairgraph.