Skip to content

Action Return TypeDicts - #240

Merged
JVickery-TBS merged 6 commits into
canada-releasefrom
feature/action-result-typing
Nov 10, 2026
Merged

JVickery-TBS merged 6 commits into
canada-releasefrom
feature/action-result-typing

Conversation

@JVickery-TBS

Copy link
Copy Markdown

idk if this is right or not? I tried to just go off of the default schemas

JVickery-TBS and others added 2 commits October 16, 2026 11:15
- Added type classes.
- Added change log file.
@wardi

wardi commented Nov 6, 2026

Copy link
Copy Markdown
Member

I would put these in types/__init__.py. They aren't just action results, they're core data structures that are used everywhere in CKAN.

- Added change log file.
- Added change log file.
@JVickery-TBS

Copy link
Copy Markdown
Author

@wardi stuff is moved now to typing/__init__.py if u want to do another gander

Comment thread ckan/types/__init__.py Resolved
Comment thread ckan/types/__init__.py Resolved
Comment thread ckan/types/__init__.py Resolved
Comment thread ckan/types/__init__.py Resolved
@wardi

wardi commented Nov 6, 2026

Copy link
Copy Markdown
Member

otherwise LGTM

- Typing class names.
@JVickery-TBS
JVickery-TBS merged commit 4288c55 into canada-release Nov 10, 2026
1 check passed
@JVickery-TBS
JVickery-TBS deleted the feature/action-result-typing branch November 10, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants