[behnam-oneschema]

Summary

Replace the 2019 prebuilt vcpkg bundle (OpenSSL 1.0.2) with a revision-verified vcpkg 2026.10.16 source build. Keep the native package set and dynamic x64-windows linkage; add the installed DLL directory to PATH. Native build failures stop the job explicitly. Guard the regression test's Unix-only shutdown signal configuration so it compiles on Windows.

Context

• Original failure: https://github.com/oneschema/rocket/actions/runs/42900508458
• Upstream defect: Response body read errors can complete unknown-length responses successfully rwf2/Rocket#3018
• Fork retirement tracking: https://github.com/oneschema/oneschema/issues/24132

Validation

• Final head: a569383.
• Final hosted CI: all 15 Linux/macOS/Windows test jobs passed, none pending: https://github.com/oneschema/rocket/actions/runs/42909420684 . Windows Debug executed all eight stream-abort regressions successfully.
• cargo test -p rocket --test response-stream-errors: all 8 passed locally.
• git diff --check, actionlint -shellcheck= .github/workflows/ci.yml, cargo fmt --all -- --check: passed before/after push. Full actionlint reports SC1001 in the unchanged contrib command.
• Fresh maintenance-base fetch/rebase and range-diff recorded before each push.
• First hosted run proved native libraries build, then exposed the Unix-only test field; the follow-up guard resolves that compile failure.
• No Rocket runtime code, monorepo pins, default branch, settings, or deployment changes.

Link to Devin session: https://app.devin.ai/sessions/f0072b93ab54435586958b6128738eee
Open in Devin Desktop: https://app.devin.ai/desktop/session/f0072b93ab54435586958b6128738eee?variant=devin
Requested by: @behnam-oneschema

[devin-ai-integration]

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

• Disable automatic comment, CI, and merge conflict monitoring

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The Windows CI workflow now installs dependencies from a verified vcpkg revision. The response-stream error test setup now clears shutdown signals on Unix.

Changes

Windows CI dependencies

Layer / File(s)	Summary
Pin and install Windows dependencies .github/workflows/ci.yml	The workflow clones and verifies a pinned vcpkg revision, bootstraps vcpkg, and installs four dependencies for x64-windows. It adds the installed binaries directory to GITHUB_PATH.

Unix test setup

Layer / File(s)	Summary
Clear Unix shutdown signals core/lib/tests/response-stream-errors.rs	Server::start clears configured shutdown signals on Unix.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · up to a5693

The Windows dependency setup is consistent with the build’s library-discovery path. No identified issue prevents merging after normal checks.

Pre-merge checks: 6

Check name	Status	Explanation
Title check		The title uses the required Conventional Commits format and accurately describes the Windows native-dependency change.
Description check		The description covers the vcpkg update, Windows test portability fix, and reported validation, all of which match the changeset.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Security Check		No unaddressed security concern was identified in the PR. The Windows dependency step verifies the vcpkg commit before running it. The other change guards test-only Unix configuration. The current rev…

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

Full details: Security Check

Explanation

No unaddressed security concern was identified in the PR. The Windows dependency step verifies the vcpkg commit before running it. The other change guards test-only Unix configuration. The current review reported zero actionable findings.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Team
• Run ID: 4a7297d6-43a4-4238-8596-682de8aee8bf

Commits

Reviewing files that changed from the base of the PR and between c94b23b and a569383.

Files selected for processing: 2

• .github/workflows/ci.yml
• core/lib/tests/response-stream-errors.rs

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

[devin-ai-integration]

@coderabbitai review

[coderabbitai]

Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[devin-ai-integration]

@behnam-oneschema CI and CodeRabbit are green on a569383. All 15 platform test jobs pass, including the eight Windows stream-abort regressions. Ready for human review and merge; runtime code and immutable monorepo pins are unchanged.