Repository navigation
fix: send one review credential on every gh call - #8
Merged
Merged
Conversation
post, threads, and complete-resolutions pick the --token-env PAT or one App installation token before the first GitHub lookup and send it on every gh call, including thread reads. Co-authored-by: Oleksiy Akimov <oakimov@users.noreply.github.com>
4 tasks done
oakimov
added a commit
that referenced
this pull request
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the thread-read credential fix from cursor-opencode-provider PR 177 (head
416e8bd00f9d9c03865cdade8642c5a127de524f).post,threads, andcomplete-resolutions.pypick one credential per run: the--token-envpersonal access token, which wins over an ambientGH_TOKENorGITHUB_TOKEN, otherwise one App installation token. That credential is selected before the first GitHub lookup and sent asGH_TOKENon everyghcall. With no credential the command exits before callinggh.threadsaccepts--token-env.scripts/review-publish.pyandscripts/complete-resolutions.pymatch that head. The tests match it except for the existingblock[1]!assertion OCP's strict test typecheck already required.docs/pr-review.mdtakes the same flag and publication-order wording, without the provider'sCURSOR_API_KEYsentence, and the App publisher note now includesthreads. The changelog records the flag and the authenticated reads.Verified with
/usr/bin/bun: typecheck and build passed.bun test ./test— 945 pass, 0 fail, 4258expect()calls, 72 files.