Repository navigation
fix: put bun and bunx on the review harness PATH - #7
Merged
Merged
Conversation
Non-interactive shells skip Bun's ~/.bashrc edit, and the isolated check resolves programs from /usr/bin. Copy bun there so setup is visible without an interactive shell, and name the program the sandbox cannot exec. Co-authored-by: Oleksiy Akimov <oakimov@users.noreply.github.com>
There was a problem hiding this comment.
No actionable findings.
Checks:
- diff: passed. The description matches the diff. Setup copies the bun binary into the system binary directory, points bunx at that file, keeps links in the local bin directory, and the sandbox names a program it cannot exec. Both changes are under the unreleased changelog.
- adversarial: passed. Candidate validation, the omission pass, and the failed-work retry check all finished. A second install picked up a changed home binary, a failed build was retried by the ordinary entrypoint, and a missing program was named. No candidate was promoted.
- isolated-check: passed (exit 0). scripts/isolated-check.sh 7 at 1998bd4 exited 0. Install, build, and typecheck passed. Unit tests 939 pass, 0 fail. Architecture tests 11 pass, 0 fail. The launcher was latest main with this pull merged, and bun resolved from the system binary directory.
Limitations:
- The macOS seatbelt path was not executed.
- The diff does not change an interactive stock-host flow, so no stock-host acceptance was run.
- This preview was not posted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Non-interactive review shells never saw
bun. The official Bun installer only adds~/.bun/binthrough~/.bashrc, which non-interactive bash returns before reading, and the isolated-check sandbox resolves programs from/opt/tools:/usr/bin:/bin:/usr/sbin. A symlink under/usr/local/bininto the home directory is not on that path, and the home directory is not mounted inside the sandbox.Cloud Agent setup now copies the
bunbinary into/usr/binand pointsbunxat that same file, with/usr/local/binlinks aimed at those copies. When the sandbox cannot exec a program, the error names it (cannot run bun: No such file or directory).The OCP environment is Config as code from
.cursor/environment.json. Draft buildbld-20261109-787004cb-425b-452c-b759-170f652bb27cof this branch succeeded, and a fresh agent booted from it resolvedbunandbunxat/usr/bin. That draft does not become the snapshot new agents use until this merges and a build ofmainis the active one.Test plan
env -i HOME="$HOME" PATH=/usr/sbin:/usr/bin:/bin bash --noprofile --norc scripts/cloud-agent-install.shexits 0 and printsBun 1.4.4env -i PATH=/usr/bin:/bin bash --noprofile --norc -c 'command -v bun; command -v bunx'prints/usr/bin/bunand/usr/bin/bunxscripts/isolated-check.sh 6withPATH=/usr/sbin:/usr/bin:/binprintsINSTALL=passed(full check exit 0: build, typecheck, 938 unit tests, 11 architecture tests)bun test ./test/review-scripts.test.ts— 29 passbld-20261109-787004cb-425b-452c-b759-170f652bb27c:command -v bunis/usr/bin/bun, a regular file, andbunxlinks tobun