Skip to content

fix: put bun and bunx on the review harness PATH - #7

Merged
caeliq-reviewer[bot] merged 1 commit into
mainfrom
cursor/bun-on-path-a977
Nov 10, 2026
Merged

caeliq-reviewer[bot] merged 1 commit into
mainfrom
cursor/bun-on-path-a977

Conversation

@oakimov

@oakimov oakimov commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

Non-interactive review shells never saw bun. The official Bun installer only adds ~/.bun/bin through ~/.bashrc, which non-interactive bash returns before reading, and the isolated-check sandbox resolves programs from /opt/tools:/usr/bin:/bin:/usr/sbin. A symlink under /usr/local/bin into the home directory is not on that path, and the home directory is not mounted inside the sandbox.

Cloud Agent setup now copies the bun binary into /usr/bin and points bunx at that same file, with /usr/local/bin links aimed at those copies. When the sandbox cannot exec a program, the error names it (cannot run bun: No such file or directory).

The OCP environment is Config as code from .cursor/environment.json. Draft build bld-20261109-787004cb-425b-452c-b759-170f652bb27c of this branch succeeded, and a fresh agent booted from it resolved bun and bunx at /usr/bin. That draft does not become the snapshot new agents use until this merges and a build of main is the active one.

Test plan

  • env -i HOME="$HOME" PATH=/usr/sbin:/usr/bin:/bin bash --noprofile --norc scripts/cloud-agent-install.sh exits 0 and prints Bun 1.4.4
  • env -i PATH=/usr/bin:/bin bash --noprofile --norc -c 'command -v bun; command -v bunx' prints /usr/bin/bun and /usr/bin/bunx
  • scripts/isolated-check.sh 6 with PATH=/usr/sbin:/usr/bin:/bin prints INSTALL=passed (full check exit 0: build, typecheck, 938 unit tests, 11 architecture tests)
  • bun test ./test/review-scripts.test.ts — 29 pass
  • Fresh agent from draft build bld-20261109-787004cb-425b-452c-b759-170f652bb27c: command -v bun is /usr/bin/bun, a regular file, and bunx links to bun
Open in Web Open in Cursor 

Non-interactive shells skip Bun's ~/.bashrc edit, and the isolated check
resolves programs from /usr/bin. Copy bun there so setup is visible
without an interactive shell, and name the program the sandbox cannot exec.

Co-authored-by: Oleksiy Akimov <oakimov@users.noreply.github.com>

@caeliq-reviewer caeliq-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No actionable findings.

Checks:

  • diff: passed. The description matches the diff. Setup copies the bun binary into the system binary directory, points bunx at that file, keeps links in the local bin directory, and the sandbox names a program it cannot exec. Both changes are under the unreleased changelog.
  • adversarial: passed. Candidate validation, the omission pass, and the failed-work retry check all finished. A second install picked up a changed home binary, a failed build was retried by the ordinary entrypoint, and a missing program was named. No candidate was promoted.
  • isolated-check: passed (exit 0). scripts/isolated-check.sh 7 at 1998bd4 exited 0. Install, build, and typecheck passed. Unit tests 939 pass, 0 fail. Architecture tests 11 pass, 0 fail. The launcher was latest main with this pull merged, and bun resolved from the system binary directory.

Limitations:

  • The macOS seatbelt path was not executed.
  • The diff does not change an interactive stock-host flow, so no stock-host acceptance was run.
  • This preview was not posted.

Runtime: linux.
Reviewed #7 at 1998bd4.

@caeliq-reviewer
caeliq-reviewer Bot merged commit 5e81aa7 into main Nov 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants