Conversation
Contributor
Author
|
addresses #19 if u wanna do this differently lmk but i think it's fine realistically |
vapebw
reviewed
Sep 25, 2026
| elif loaded[key] != name: | ||
| errors.append("extension %s: zphp reports it as %s" % (name, loaded[key])) | ||
| for name in available.values(): | ||
| expected = sorted(manifest["extensions"][name]["functions"], key=str.lower) |
Contributor
There was a problem hiding this comment.
Isn't this comparison circular? expected comes from the manifest, while get_extension_funcs() gets its built in function list from extensions_generated.zig, which is generated from that same manifest.
This seems unable to catch a function being assigned to the wrong extension, should extension ownership also be checked against the reference php inventory?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.