Repository navigation
fix(#3359): legacy highlight groups will not be overwritten following ColorScheme autocommand - #3360
Merged
Merged
Conversation
alex-courtis
requested changes
Oct 6, 2026
alex-courtis
left a comment
alex-courtis
left a comment
Member
There was a problem hiding this comment.
Nice one, the test case passes on this branch.
Good work identifying the performance issue. Unfortunately, we can't change the default tables to a map: it is defined as a list to preserve the ordering, for :NvimTreeHiTest and similar.
Suggestion:
- middle loop body is only done when
local hl_to = vim.api.nvim_get_hl(0, { name = to })is defined - yes, it would need to be a linear lookup, however it would only be executed when necessary
…one only links to default
Contributor
Author
|
Yeah, for ~80 items linear lookups are probably better. Should have realized that. |
alex-courtis
approved these changes
Oct 7, 2026
alex-courtis
left a comment
alex-courtis
left a comment
Member
There was a problem hiding this comment.
Many thanks for your contribution! Tests working as expected.
alex-courtis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3359
I have also changed the type of the highlight defaults table to a map for faster lookup.