Repository navigation
Run the verify-api action on this repository's own api/ - #105
Merged
Merged
Conversation
…n purpose for the first run) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Public API files match the build |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new workflow,
verify-api.yml, runs theverify-apiaction on this repository's ownapi/on every pull request. It uses the action from the checkout (uses: ./verify-api) with the released tool, so the action is tested end to end, and withcomment: true, so the comment is tested too.Tested on this pull request, in two pushes
Stale.
api/was deliberately stale: one property removed fromNullean.PublicApi.Diff.api. Theverify-apijob failed, and so did the build job'sverifyapistep. The action posted this comment:Restored. With the file back, both jobs passed. The same comment was updated in place to "Public API files match the build"; it's still the pull request's only comment.
A fix to the action
On a pull request from a fork, the token can't write. The comment calls now warn ("the token needs pull-requests: write") instead of failing the step, and failing is left to the check, which still exits 5 when the files are stale.
🤖 Generated with Claude Code