Repository navigation
Name a changed parameter by its position - #104
Merged
Merged
Conversation
A parameter's changes were labelled with its new name, so a parameter renamed and made params read
"parameter rest" one way round and "parameter p0" the other. The rename itself was already reported by position
("parameter 1 name"); every other part of a parameter is now too. CsCheck's mirror property found it on CI.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Mpdreamz
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CsCheck mirror property failed on #103's CI with seed
7EiLdrYJA8Z9. That failure is a bug on main since #96, not a regression in #103.A parameter's changes were labelled with its new name. So a parameter that was renamed and also made
paramsreadparameter restin one direction andparameter p0in the other. The rename itself was already reported by position (parameter 1 name), and now every other part of a parameter is too:Checks: the seed passes with the fix.
mise run cipasses: 81 library tests and 630 tool tests.🤖 Generated with Claude Code