Repository navigation
fix(#626): a Slack file download's 403 gets the files:read reinstall hint - #627
Merged
Merged
Conversation
…hint Slack now answers 403 to a token without files:read, where it once served a sign-in page with status 200. SlackWeb.download reports 401/403 as `forbidden`, and fetchFiles gives it the same reinstall hint as `size_mismatch`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #626.
Problem
files:readdownloads a shared file; it used to serve a 200 sign-in page.⚠️ not sent: slack file download: HTTP 403.Solution
SlackWeb.download(src/bridge/web.ts) reports 401/403 asSlackErrorcodeforbidden.Relay.fetchFiles(src/bridge/relay.ts) givesforbiddenthe same "does the app have files:read? reinstall it from the current manifest" hint assize_mismatch(kept for the old 200 behaviour). Covers both the local and org bridges, which sharefetchFiles.docs/slack-bridge.md§Files updated.Tests
forbiddenhosted file served as 403;tests/integration/slack.test.ts"a Slack file that can't come along…" asserts the hint for it.bun run typecheckclean;bun test tests/integration/slack.test.ts src/bridge/bridge.test.ts: 46 pass.Parity: no
docs/parity.mdcell changes (error text only, same behaviour on both bridges).🤖 Generated with Claude Code