Repository navigation
Conversation
Add a `cache` input (default `true`, so nothing changes for existing callers). Release jobs can pass `cache: false` so they never restore a pnpm/npm store that another workflow could have poisoned, which zizmor flags as `cache-poisoning` in publishing workflows. `false` also turns off setup-node's automatic `package-manager-cache`. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Both setup paths consistently disable caching when requested, preserve existing defaults, and have no unresolved findings.
No open issues 🎉
What changed in this PR
Adds an optional dependency-cache opt-out to the shared setup-environment action for publishing and other sensitive jobs, while preserving caching by default.
Changes:
- Introduces a
cacheinput defaulting to"true". - Disables explicit and automatic package-manager caching when opted out, in both Node.js setup paths.
| File | Description |
|---|---|
actions/setup-environment/action.yml |
Adds the cache input and applies it to both Node.js setup steps. |
Review effort: Balanced
MattIPv4
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
cacheinput tosetup-environment. It defaults totrue, so nothing changes for current callers, andfalseturns off both setup-node'scacheand its automaticpackage-manager-cache.Jobs that publish (and hold
id-token: write) shouldn't restore a pnpm/npm store that another workflow could have poisoned, which is what zizmor'scache-poisoningaudit flags. Once this lands, doc-kit's publish job will passcache: falseinstead of inlining these steps, as discussed in nodejs/doc-kit#1178.cc @MattIPv4