Skip to content

bench_runner: replace Kahan summation with MathSumPrecise #67222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LiviaMedeiros wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −13
Open

bench_runner: replace Kahan summation with MathSumPrecise #67222

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
faa106d
lib: replace Kahan summation with `MathSumPrecise`
LiviaMedeiros Nov 3, 2026
78cc0f1
Update lib/internal/bench_runner/benchmark.js
LiviaMedeiros Nov 3, 2026
525314b
squash: import `SafeArrayIterator`
LiviaMedeiros Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions lib/internal/bench_runner/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,14 @@ const {
MathMin,
MathRound,
MathSqrt,
MathSumPrecise,
Number,
NumberIsFinite,
NumberMAX_SAFE_INTEGER,
ObjectFreeze,
ObjectKeys,
PromiseWithResolvers,
SafeArrayIterator,
SafeSet,
StringPrototypeToLowerCase,
} = primordials;
Expand Down Expand Up @@ -485,18 +487,6 @@ class BenchContext {
}
}

function arithmeticMean(values) {
let sum = 0;
let compensation = 0;
for (let i = 0; i < values.length; i++) {
const adjusted = values[i] - compensation;
const next = sum + adjusted;
compensation = (next - sum) - adjusted;
sum = next;
}
return sum / values.length;
}

function summarizeSamples(samples) {
const rates = [];
let min = Infinity;
Expand All @@ -508,7 +498,7 @@ function summarizeSamples(samples) {
max = MathMax(max, rate);
}

const mean = arithmeticMean(rates);
const mean = MathSumPrecise(new SafeArrayIterator(rates)) / rates.length;
let variance = 0;
for (let i = 0; i < rates.length; i++) {
const difference = rates[i] - mean;
Expand Down
Loading