Repository navigation
Conversation
When a peer sends GOAWAY(NO_ERROR), the session starts a graceful close on its own, which disarmed the detection of nghttp2 internally terminating the session after a protocol error. Instead, also treat it as an internal termination when nghttp2 no longer wants to read or write while we still have open streams. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: nodejs#66641 Reviewed-By: Tim Perry <pimterry@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
pimterry
approved these changes
Nov 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v24.x-staging #67221 +/- ##
=================================================
+ Coverage 90.31% 90.41% +0.10%
=================================================
Files 711 717 +6
Lines 228425 240612 +12187
Branches 43160 45911 +2751
=================================================
+ Hits 206293 217540 +11247
- Misses 14090 14520 +430
- Partials 8042 8552 +510
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #66641 to v24.x.
The commit cherry-picks without conflicts. Verified locally: the new test passes with the fix and times out without it on v24.x-staging.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Sfj4nDjYpZJaeuUs7tqFfV