Repository navigation
Conversation
Cancel pending TLS writes after a fatal error so HTTP/2 session cleanup can complete. Add coverage for TLS 1.3 client certificate rejection. Fixes: nodejs#67213 Signed-off-by: inoway46 <inoueyuya416@gmail.com> Assisted-by: Codex
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http2
inoway46
marked this pull request as ready for review
November 3, 2026 07:03
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67215 +/- ##
=======================================
Coverage 90.71% 90.71%
=======================================
Files 797 797
Lines 278898 278902 +4
Branches 53627 53628 +1
=======================================
+ Hits 252995 253006 +11
+ Misses 16269 16264 -5
+ Partials 9634 9632 -2
🚀 New features to boost your workflow:
|
Allow both OpenSSL and BoringSSL names for the same TLS alert in the HTTP/2 fatal TLS error test. Keep the cleanup assertions unchanged. Signed-off-by: inoway46 <inoueyuya416@gmail.com> Assisted-by: Codex
Contributor
Author
|
Verified with v26.13.0 source builds: the patch resolves the session/socket leak, and the tested GOAWAY scenarios still pass. The regression test passed 20 consecutive runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destroy the TLS socket after a fatal TLS error so pending writes cannot block HTTP/2 session cleanup.
This reproduces on v26.13.0 but not on main, apparently due to the OpenSSL 4.1.0 upgrade in #66971. HTTP/2 should still ensure session cleanup completes when its TLS transport becomes unusable. This change is intended to make that behavior explicit and provide a candidate for backporting to v26 without a major OpenSSL upgrade.
Fixes: #67213