Repository navigation
build,win: minify pgo training build - #67214
Open
StefanStojanovic wants to merge 1 commit into
Open
StefanStojanovic wants to merge 1 commit into
StefanStojanovic wants to merge 1 commit into
Conversation
Signed-off-by: StefanStojanovic <stefan.stojanovic@janeasystems.com>
StefanStojanovic
added
windows
aduh95
approved these changes
Nov 3, 2026
aduh95
added
fast-track
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with @aduh95 and @sxa in slack, release builds on Windows take additional 20 minutes, because the first, PGO isntrumented build, is signed, packed, generates MSI, etc. All of these things are unnecessary and can be omitted. This PR does it by clearing certain flags when release PGO instrumented build is detected. Once this lands it should be backported to v24 and v26 LTS branches too.
I will test building this in the Release CI before landing (no issues expected).