Repository navigation
build: sort the ICU source lists - #67206
Open
codebytere wants to merge 1 commit into
Open
codebytere wants to merge 1 commit into
codebytere wants to merge 1 commit into
Conversation
configure.py lists the ICU source files in the order os.walk() returns them, which depends on the file system. That order ends up in icu_config.gypi and in the generated build files, so it differs between machines. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
nodejs-github-bot
added
build
richardlau
approved these changes
Nov 2, 2026
richardlau
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configure.pylists the ICU source files in the orderos.walk()returns them, which depends on the file system. That order ends up inicu_config.gypiand in the generated build files, so it differs between machines.This sorts the list.
Disclosure: the code and this description were written by Claude Code, directed and reviewed by @codebytere.