[araujogui]

Buffer body spans in on_body() and deliver them to JS once per execute() call instead of once per chunk. A body sent as many small chunks no longer costs one C++ to JS call and Buffer per chunk.

Chunks that arrive in the same read now produce a single 'data' event on IncomingMessage. Chunk boundaries were never documented, but code that treats each 'data' event as a full message could break, so this needs a CITGM run.

[nodejs-github-bot]

Review requested:

• @nodejs/http
• @nodejs/net
• @nodejs/performance

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[ronag]

Any benchmark/perf numbers?

[araujogui]

https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1903/

Benchmark

++ ./node-master benchmark/compare.js --set CPUSET=0-11 --analyze --old ./node-master --new ./node-pr --filter bench-parser-chunked -- http
                                                             confidence   improvement   accuracy (*)    (**)   (***)
http/bench-parser-chunked.js n=500 len=65536 chunkSize=1     ***          +3726.84 %   ±15.61%  ±21.03%  ±27.92%
http/bench-parser-chunked.js n=500 len=65536 chunkSize=16    ***          +2122.98 %   ±38.26%  ±51.57%  ±68.46%
http/bench-parser-chunked.js n=500 len=65536 chunkSize=256   ***           +522.99 %   ±40.48%  ±54.55%  ±72.41%
http/bench-parser-chunked.js n=500 len=65536 chunkSize=4096  ***            +43.47 %   ±11.18%  ±14.93%  ±19.55%

                                                                -3742.4%           0%           +3742.4%
http/bench-parser-chunked.js n=500 len=65536 chunkSize=1                         |███████████████████  +3726.84% ***
http/bench-parser-chunked.js n=500 len=65536 chunkSize=16                        |██████████░          +2122.98% ***
http/bench-parser-chunked.js n=500 len=65536 chunkSize=256                       |██                   +522.99% ***
http/bench-parser-chunked.js n=500 len=65536 chunkSize=4096                      |                     +43.47% ***

Rates were scaled by 1000x into HdrHistogram (3 significant figures).
Use --scale to adjust precision if needed.

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 4 comparisons, you can thus
expect the following amount of false-positive results:
  0.20 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.04 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

The stars above are per-benchmark and uncorrected. Adjusting for the size of
this comparison set (Holm-Bonferroni), 4 comparisons remain significant at 5%.

[ronag]

RSLGTM

[codecov]

Codecov Report

❌ Patch coverage is 79.41176% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.71%. Comparing base (97aed16) to head (8f623b9).
⚠️ Report is 62 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_http_parser.cc	79.41%	4 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #67187      +/-   ##
==========================================
+ Coverage   90.67%   90.71%   +0.03%     
==========================================
  Files         797      797              
  Lines      278773   278924     +151     
  Branches    53607    53639      +32     
==========================================
+ Hits       252778   253023     +245     
+ Misses      16356    16264      -92     
+ Partials     9639     9637       -2     

Files with missing lines	Coverage Δ
src/node_http_parser.cc	84.96% <79.41%> (-0.38%)	⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ronag]

if we could somehow avoid the callback that would also be great.

[araujogui]

if we could somehow avoid the callback that would also be great.

I tried passing the body to kOnMessageComplete. It breaks test-http-pause-no-dump: kOnBody's MakeCallback drains nextTicks before end, and 'data' handlers depend on that.

[mcollina]

Lgtm

[mcollina]

Given the change, I don't think this needs to be semver-major.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78835/