deps: update v8 to 15.7 by legendecas · Pull Request #66799 · nodejs/node

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.71%. Comparing base (c99ebf2) to head (b70aa79).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #66799      +/-   ##
==========================================
- Coverage   92.99%   90.71%   -2.29%     
==========================================
  Files         428      797     +369     
  Lines      195633   278898   +83265     
  Branches    30281    53634   +23353     
==========================================
+ Hits       181937   252993   +71056     
- Misses      13369    16258    +2889     
- Partials      327     9647    +9320

see 499 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

legendecas · 2026-10-29T21:17:24Z

Updated this PR to the stable branch of V8 15.7.

nodejs-github-bot · 2026-10-30T00:16:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/78719/

legendecas · 2026-10-30T02:40:19Z

~~@nodejs/v8-update CI is green. Please take a look, thanks~~

legendecas · 2026-10-30T02:42:38Z

ah also https://ci.nodejs.org/job/node-test-commit-v8-linux/7472/

nodejs-github-bot · 2026-10-30T02:42:55Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7472/

nodejs-github-bot · 2026-10-30T02:43:20Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7472/

nodejs-github-bot · 2026-10-30T02:43:30Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7472/

legendecas · 2026-10-30T02:50:18Z

22:45:02 FAILED: [code=1] gen/metagen/instance-types.h gen/metagen/layouts.json 
22:45:02 python3 ../../tools/metagen/metagen.py --depfile gen/metagen/instance-types.h.d --driver ../../tools/metagen/harvest-driver.cc --v8-root ../.. --build-dir . --source-root ../../ --out gen/metagen --flags-from-target //:v8_base_without_compiler --flags-toolchain //build/toolchain/linux:clang_s390x --flags-dependency obj/v8_base_without_compiler.ninja --clang-resource-dir ../../../../../../../../../usr/lib/clang/20 --driver-mode=gcc --libclang-dir ../../third_party/llvm-libclang
22:45:02 Traceback (most recent call last):
22:45:02   File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/third_party/llvm-libclang/bindings/python/clang/cindex.py", line 4502, in get_cindex_library
22:45:02     library = cdll.LoadLibrary(self.get_filename())
22:45:02               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
22:45:02   File "/usr/lib64/python3.11/ctypes/__init__.py", line 454, in LoadLibrary
22:45:02     return self._dlltype(name)
22:45:02            ^^^^^^^^^^^^^^^^^^^
22:45:02   File "/usr/lib64/python3.11/ctypes/__init__.py", line 376, in __init__
22:45:02     self._handle = _dlopen(self._name, mode)
22:45:02                    ^^^^^^^^^^^^^^^^^^^^^^^^^
22:45:02 OSError: /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/third_party/llvm-libclang/lib/libclang.so: ELF file data encoding not big-endian
22:45:02 
22:45:02 During handling of the above exception, another exception occurred:
22:45:02 
22:45:02 Traceback (most recent call last):
22:45:02   File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/s390x.release/../../tools/metagen/metagen.py", line 490, in <module>
22:45:02     sys.exit(main())
22:45:02              ^^^^^^
22:45:02   File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/s390x.release/../../tools/metagen/metagen.py", line 367, in main
22:45:02     cpp_res = cpp_hier.scan_cpp(v8_root, driver_path, flags, parse_cwd=parse_cwd)
22:45:02               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
22:45:02   File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/metagen/cpp_hier.py", line 291, in scan_cpp
22:45:02     index = cindex.Index.create()
22:45:02             ^^^^^^^^^^^^^^^^^^^^^
22:45:02   File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/third_party/llvm-libclang/bindings/python/clang/cindex.py", line 3280, in create
22:45:02     return Index(conf.lib.clang_createIndex(excludeDecls, 0))
22:45:02                  ^^^^^^^^
22:45:02   File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/third_party/llvm-libclang/bindings/python/clang/cindex.py", line 260, in __get__
22:45:02     value = self.wrapped(instance)
22:45:02             ^^^^^^^^^^^^^^^^^^^^^^
22:45:02   File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/third_party/llvm-libclang/bindings/python/clang/cindex.py", line 4474, in lib
22:45:02     lib = self.get_cindex_library()
22:45:02           ^^^^^^^^^^^^^^^^^^^^^^^^^
22:45:02   File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/third_party/llvm-libclang/bindings/python/clang/cindex.py", line 4510, in get_cindex_library
22:45:02     raise LibclangError(msg)
22:45:02 clang.cindex.LibclangError: /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/third_party/llvm-libclang/lib/libclang.so: ELF file data encoding not big-endian To provide the path to the directory containing libclang, you can use the environment variable LIBCLANG_LIBRARY_PATH or call Config.set_library_path(). Alternatively, you can specify the path of the library file using LIBCLANG_LIBRARY_FILE or Config.set_library_file().

Build failed on power9le and s390x /cc @nodejs/platform-s390 @nodejs/platform-ppc

richardlau · 2026-10-30T03:28:16Z

@legendecas I think we need to mirror the change from a3fe991 / https://chromium-review.googlesource.com/c/v8/v8/+/8524366 in

node/tools/make-v8.sh

Line 73 in 8d514c7

    
           gn gen -v "out.gn/$BUILD_ARCH_TYPE" --args="$GN_COMPILER_OPTS is_component_build=false is_debug=false v8_target_cpu=\"$TARGET_ARCH\" target_cpu=\"$TARGET_ARCH\" v8_enable_backtrace=true v8_use_metagen_instance_types=false ${GN_RUST_ARGS} $CC_WRAPPER"

i.e. change v8_use_metagen_instance_types=false to v8_use_metagen=false.

legendecas · 2026-10-30T04:44:05Z

Hmm maybe a3fe991 is not enough. I'll take a look tomorrow.

richardlau · 2026-10-30T13:06:57Z

Hmm maybe a3fe991 is not enough. I'll take a look tomorrow.

That only updates the gyp based build used by Node.js. The V8 CI runs V8's gn based build.

FWIW in https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7472/consoleFull we can see

02:44:39 WARNING at the command-line "--args":1:279: Build argument has no effect.
02:44:39 is_clang=true clang_base_path="/usr" clang_use_chrome_plugins=false treat_warnings_as_errors=false use_custom_libcxx=false clang_version="20" is_component_build=false is_debug=false v8_target_cpu="s390x" target_cpu="s390x" v8_enable_backtrace=true v8_use_metagen_instance_types=false rustc_version="1.88.0" rust_sysroot_absolute="/usr" rust_bindgen_root="/usr" cc_wrapper="ccache"
02:44:39                                                                                                                                                                                                                                                                                       ^----
02:44:39 The variable "v8_use_metagen_instance_types" was set as a build argument
02:44:39 but never appeared in a declare_args() block in any buildfile.
02:44:39 
02:44:39 To view all possible args, run "gn args --list <out_dir>"
02:44:39 
02:44:39 The build continued as if that argument was unspecified.
02:44:39

nodejs-github-bot · 2026-10-30T13:10:22Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7475/

nodejs-github-bot · 2026-10-30T13:12:22Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7475/

nodejs-github-bot · 2026-10-30T13:12:52Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7475/

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 15.7. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/8533406 Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: nodejs#66601 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Original commit message: [platform] support madvise(3C) across ALL illumos revisions In illumos, madvise(3C) now takes `void *` for its first argument post-illumos#14418, but uses `caddr_t` pre-illumos#14418. This fix will detect if the illumos mman.h file in use is pre-or-post-illumos#14418 so builds can work either way. Co-Authored-By: Dan McDonald <danmcd@mnx.io> Refs: nodejs#65161 Change-Id: I87faa4e7042cf9b02449bd3debfdd7fed30e5d3c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8532506 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#111024} Refs: v8/v8@5dea94c

Original commit message: [sandbox] fix dispatch table access on illumos illumos pointers are VA48, can allocate from the top of the 64-bit range as well. Co-Authored-By: Dan McDonald <danmcd@mnx.io> Refs: nodejs#65161 Change-Id: I7d803ca0da2ab6c7cc206cb964d63683523a13da Refs: v8/v8@011b2de

Original commit message: Add V8_DISABLE_PRESERVE_MOST for embedders to opt out of preserve_most preserve_most changes the calling convention, which clang encodes in the mangled name (e.g. "U" instead of "A" for cdecl in the Microsoft C++ ABI). A consumer whose toolchain does not support the attribute would reference a differently mangled symbol. This patch adds a V8_DISABLE_PRESERVE_MOST to disable it, so that it's possible to link to V8 using different toolchains, as long as the value of it is set consistently. Refs: nodejs#55784 Change-Id: I67b49e739942d4026ac060be35bb39ec22256cbd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8532546 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#111381} Refs: v8/v8@c389861

Original commit message: [tracing] do not define legacy tracing classes when using Perfetto Otherwise the Windows build of Node.js fails with `undefined symbol` errors due to the missing destructor. Change-Id: Id0841aed2f0a8f0cfe8889c39150552e31ee5f96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8580049 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Chengzhong Wu <cwu631@bloomberg.net> Commit-Queue: Chengzhong Wu <cwu631@bloomberg.net> Cr-Commit-Position: refs/heads/main@{#110947} Refs: v8/v8@785a2ea

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8459484 Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8524366 Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

legendecas · 2026-11-03T17:27:14Z

@@ -1,5 +1,6 @@
 {
  "NODE_MODULE_VERSION": [
+    { "modules": 155, "runtime": "node", "variant": "v8_15.7", "versions": "28.0.0-pre" },


I think this should follow the conclusion from nodejs/Release#1194 if this needs to be 27.0.0-pre or 28.0.0-pre.

legendecas · 2026-11-03T17:29:27Z

Updated to V8 v15.7 stable release and this should be ready. One (blocking) issue might be the nodejs/Release#1194 that if we should carry 28.0.0-pre for the NODE_MODULE_VERSION bump.

joyeecheung

LGTM % inconclusive nodejs/Release#1194

nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels Oct 16, 2026

legendecas added the v8 engine Issues and PRs related to the V8 dependency. label Oct 16, 2026

legendecas closed this Oct 27, 2026

legendecas mentioned this pull request Oct 29, 2026

deps: update v8 to 15.8 #67070

Draft

legendecas reopened this Oct 29, 2026

legendecas force-pushed the v8-15.7 branch from 8abb937 to a3fe991 Compare October 29, 2026 14:24

legendecas marked this pull request as ready for review October 29, 2026 15:09

richardlau added the semver-major PRs that contain breaking changes and should be released in the next major version. label Oct 30, 2026

legendecas force-pushed the v8-15.7 branch from a3fe991 to 514db2e Compare October 30, 2026 13:01

richardlau approved these changes Oct 31, 2026

View reviewed changes

legendecas mentioned this pull request Nov 3, 2026

build: set V8_DISABLE_PRESERVE_MOST #67093

Merged

legendecas and others added 11 commits November 3, 2026 12:07

deps: update V8 to 15.7.112.25

ca74ecb

deps: update Rust crates for V8 15.7.112.25

079d524

build: reset embedder string to "-node.0"

39afeb7

src: update NODE_MODULE_VERSION to 155

cf013dc

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 15.7. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

build: add simdutf dependency to torque_base

f5fe81f

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8459484 Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

build: use v8_use_metagen in build flags

b70aa79

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8524366 Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

legendecas force-pushed the v8-15.7 branch from 514db2e to b70aa79 Compare November 3, 2026 17:25

legendecas commented Nov 3, 2026

View reviewed changes

joyeecheung approved these changes Nov 3, 2026

View reviewed changes

Conversation

legendecas commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 16, 2026

Uh oh!

nodejs-github-bot commented Oct 16, 2026

Uh oh!

nodejs-github-bot commented Oct 16, 2026

Uh oh!

nodejs-github-bot commented Oct 16, 2026

Uh oh!

nodejs-github-bot commented Oct 16, 2026

Uh oh!

legendecas commented Oct 27, 2026

Uh oh!

nodejs-github-bot commented Oct 29, 2026

Uh oh!

codecov Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

legendecas commented Oct 29, 2026

Uh oh!

nodejs-github-bot commented Oct 30, 2026

Uh oh!

legendecas commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

legendecas commented Oct 30, 2026

Uh oh!

nodejs-github-bot commented Oct 30, 2026

Uh oh!

nodejs-github-bot commented Oct 30, 2026

Uh oh!

nodejs-github-bot commented Oct 30, 2026

Uh oh!

legendecas commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richardlau commented Oct 30, 2026

Uh oh!

legendecas commented Oct 30, 2026

Uh oh!

richardlau commented Oct 30, 2026

Uh oh!

nodejs-github-bot commented Oct 30, 2026

Uh oh!

nodejs-github-bot commented Oct 30, 2026

Uh oh!

nodejs-github-bot commented Oct 30, 2026

Uh oh!

legendecas Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

legendecas commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joyeecheung left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

legendecas commented Oct 16, 2026 •

edited

Loading

codecov Bot commented Oct 29, 2026 •

edited

Loading

legendecas commented Oct 30, 2026 •

edited

Loading

legendecas commented Oct 30, 2026 •

edited

Loading

legendecas commented Nov 3, 2026 •

edited

Loading