[fatihguzeldev]

when an upload was canceled, its queued data was discarded but still counted toward the session's memory limit. that could make later requests on the same session fail with NGHTTP2_ENHANCE_YOUR_CALM.

cleanup now subtracts those bytes before running the write callbacks. the test checks both cancellation by the server and destroy() from a write callback.

Fixes: #66742

[nodejs-github-bot]

Review requested:

• @nodejs/http2
• @nodejs/net

[github-actions]

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

• the guide for first-time contributors
• the contribution and automation policies
• the pull request guide
• the AI use policy
• the Code of Conduct

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

[pimterry]

Hi @fatihguzeldev, the core change here looks good but the CPP linting is failing, can you take a look?

[fatihguzeldev]

@pimterry thanks for the review, fixed the formatting.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.69%. Comparing base (38aa1f3) to head (e02ea14).
⚠️ Report is 283 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #66784      +/-   ##
==========================================
+ Coverage   90.49%   90.69%   +0.20%     
==========================================
  Files         797      797              
  Lines      277503   278898    +1395     
  Branches    53329    53626     +297     
==========================================
+ Hits       251124   252960    +1836     
+ Misses      16785    16299     -486     
- Partials     9594     9639      +45     

see 140 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[inoway46]

@fatihguzeldev Sorry, I missed this PR when working on #67113, which has now landed with the same fix.

The partial-send and write-callback destruction cases here add useful coverage beyond the landed test. I verified that your tests pass with my local main build. Would you be interested in updating this PR to keep the tests and drop the C++ changes?

[fatihguzeldev]

@inoway46 well, that's one way to get my fix into main. would've preferred to land it through this PR, especially since it was already open and approved. let's coordinate a bit better next time so we don't end up here again.

i'll update this one to keep the extra tests and drop the rest. thanks for checking.

[fatihguzeldev]

@pimterry you approved #66784 on october 28, and i addressed the formatting feedback that day. #67113 was opened the following day with the exact same two-line C++ fix. you then approved and queued that PR while #66784 was still open.

why was the later PR taken forward instead of the earlier one you had already reviewed and approved? i've updated #66784 to keep the additional tests, but i'd like to understand how that decision was made.

[pimterry]

Hi @fatihguzeldev. Sorry about that, not intentional. There's a lot going on right now and I didn't realise.

[pimterry]

Happy to land this for the extra test coverage. Would you mind squashing the commits into one, with an updated commit message covering the tests specifically? The commit message will become the addition in the changelog once it's merged.

[fatihguzeldev]

@pimterry done.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78805/