Repository navigation
Conversation
nodejs-github-bot
added
needs-ci
trivikr
added
the
request-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66221 +/- ##
==========================================
- Coverage 90.69% 90.69% -0.01%
==========================================
Files 797 797
Lines 278883 278893 +10
Branches 53632 53623 -9
==========================================
+ Hits 252941 252943 +2
- Misses 16300 16305 +5
- Partials 9642 9645 +3
🚀 New features to boost your workflow:
|
trivikr
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Member
Author
|
cc @mcollina Can you review this? |
RealFSProvider.mkdirSync()/mkdir() forwarded the raw fs.mkdirSync()
result, which for { recursive: true } is the absolute backing-directory
path of the first created directory. VirtualFileSystem#toMountedPath()
then joined the mount point with it, producing <mount>/<root>/a instead
of <mount>/a, so the returned path failed fs.existsSync().
Reuse the existing #resolvedToVfsPath() helper (as realpath does) to
translate the result back to a provider-relative VFS path, matching
MemoryProvider.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: opencode
trivikr
force-pushed
the
vfs-normalize-realfsprovider-mkdir-return-paths
branch
from
November 2, 2026 21:27
3b52939 to
43b6f0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66220
RealFSProvider.mkdirSync()/mkdir()forwarded the rawfs.mkdirSync()result, which for{ recursive: true }is the absolute backing-directory path of the first created directory.VirtualFileSystem#toMountedPath()then joined the mount point with it, producing<mount>/<root>/ainstead of<mount>/a, so the returned path failedfs.existsSync().Reuse the existing
#resolvedToVfsPath()helper (as realpath does) to translate the result back to a provider-relative VFS path, matching MemoryProvider.Assisted-by: opencode