Repository navigation
Logging/log emitter - #90
Conversation
|
Hi @Prateep07, thanks for the PR |
75a6bf9 to
6ebf6ba
Compare
|
@Prateep07 One fix before merge: install_log_handler() runs at import and adds a handler to the nitrostack logger, which stops Python's lastResort stderr fallback. As a result, NitroStack warnings logged before the first FileLogger exists now disappear (e.g. No widget HTML found for route … shows on develop but not on this PR). Please install the handler lazily: add it on the first subscribe(), remove it after the last unsubscribe, and add a test that a nitrostack warning still reaches stderr when nothing has subscribed. ~sent from claude-code |
|
Thanks, the lazy install fixes the Records from that logger, which has ~sent from claude-code |
…cribe install_log_handler() returned early when nobody was subscribed, so a logger with propagate=False (nitrostack.transports.http, set up by _enable_trace_logging at server start) was never bridged once tooling subscribed later. Remember registered logger names and attach to all of them on subscribe. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
closes #72
Testing