Repository navigation
Feature/issue 24 wire alignment - #37
Open
jpsiddharth2008 wants to merge 10 commits into
Open
jpsiddharth2008 wants to merge 10 commits into
jpsiddharth2008 wants to merge 10 commits into
Conversation
Shreyavemana
left a comment
Collaborator
There was a problem hiding this comment.
I tested the PR #37 locally and these are the results:
- The targeted tests pass (46 passed across the two test runs).
- However, the full test suite fails during collection because existing tests still import modules and functions removed by this PR:
test_mcp20_blueprint.py— missingnitrostack.transports.dispatchtest_mcp20_deprecated.py— missingnitrostack.transports.dispatchtest_mcp20_jsonrpc_wire.py— missingnitrostack.transports.dispatchtest_mcp20_stateless_http.py— cannot importbuild_ping_response
Please update or remove the affected tests as appropriate and rerun the full test suite.
4 tasks
jpsiddharth2008
force-pushed
the
feature/issue-24-wire-alignment
branch
from
October 28, 2026 13:06
e458282 to
0cc7d68
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24. PR #34 is merged; PR #36 remains a dependency and should merge first.
Purpose
Align modern MCP wire behavior while retaining official MCP ownership of
/mcp.This update publishes the previously local issue-specific implementation and
rebases the stack onto current
develop(63ecd92). The PR targetsdevelop.Changes
-32021with its message and regression test;NitroStack task-capability enforcement remains deferred to the tasks issue.
_meta.serverInfoin the shared discovery builder and preserve cachemetadata and compatibility fields where allowed by the wire version.
resultTypefields for ordinary tool/resource/promptresults, preserving existing metadata and specialized result types.
or replaying the body. Official MCP owns method/name/header validation and routing.
Preserve legacy-compatible auto initialization and requests.
method/name validators. Replace their test consumers with real HTTP coverage.
Post-rebase verification
Complete collection: 954 tests, including 99 issue #24 wire cases.
MCP 2.2.0. No exclusions or new skips/xfail markers:
Windows hit the unchanged localhost OAuth discovery test with WinError 10053.
The complete repeat failed in both unchanged live OAuth discovery socket tests.
This intermittent error was also reproduced on the unchanged foundation during
the earlier investigation. Exact results are recorded in
docs/pr37-review-verification.md; Windows is not claimed green. No socket testwas excluded or changed.
A fresh archive of current develop
63ecd92reproduced both errors under thesame Windows Python/MCP environment: 72 passed, 2 failed across the OAuth
and SecretValue modules. This comparison is included in the verification report.
git diff --checkpasses. The table above records local MCP 2.2.0 runs.Hosted CI: all checks passed
GitHub Actions run 40693461563
passed on the rebased head
0cc7d68, using MCP 2.3.0:No new runtime dependencies, version changes, OAuth-client or spillover changes
are included.
See
docs/issue24-wire-alignment.mdfor the architecture and coverage mapping,and
docs/pr37-review-verification.mdfor exact results and dependency history.