Skip to content

fix(notifications): notify mentioned users about mentions by guests - #9392

Merged
mejo- merged 1 commit into
mainfrom
fix/mention_by_guest
Oct 15, 2026
Merged

mejo- merged 1 commit into
mainfrom
fix/mention_by_guest

Conversation

@mejo-

@mejo- mejo- commented Oct 15, 2026

Copy link
Copy Markdown
Member

Store the guest name as a separate subject parameter and render it as a guest rich object labelled "(guest)", so it cannot be mistaken for an instance user. Notifications without a valid source are marked as processed, which removes broken rows from earlier mentions. Mentions are now rate limited for anonymous requests as well.

Fixes #8743

Assisted-by: ClaudeCode:claude-opus-5-5

馃弫 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

馃 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

@mejo- mejo- self-assigned this Oct 15, 2026
@mejo- mejo- added bug Something isn't working 3. to review labels Oct 15, 2026
@github-project-automation github-project-automation Bot moved this to 馃Л Planning evaluation (don't pick) in 馃摑 Productivity team Oct 15, 2026
@mejo- mejo- moved this from 馃Л Planning evaluation (don't pick) to 馃憖 In review in 馃摑 Productivity team Oct 15, 2026
@mejo-

mejo- commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

/backport to stable34

@mejo-

mejo- commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

/backport to stable35

Store the guest name as a separate subject parameter and render it as a
guest rich object labelled "(guest)", so it cannot be mistaken for an
instance user. Notifications without a valid source are marked as
processed, which removes broken rows from earlier mentions. Mentions are
now rate limited for anonymous requests as well.

Fixes #8743

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
@mejo-
mejo- force-pushed the fix/mention_by_guest branch from 632b0ba to e56213b Compare October 15, 2026 09:43
@mejo- mejo- changed the title feat(notifications): notify mentioned users about mentions by guests fix(notifications): notify mentioned users about mentions by guests Oct 15, 2026
@mejo-
mejo- merged commit eacb75e into main Oct 15, 2026
67 of 69 checks passed
@mejo-
mejo- deleted the fix/mention_by_guest branch October 15, 2026 12:08
@github-project-automation github-project-automation Bot moved this from 馃憖 In review to 鈽戯笍 Done in 馃摑 Productivity team Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

Status: 鈽戯笍 Done

Development

Successfully merging this pull request may close these issues.

Notifier.php bug? NC Error log

2 participants