Repository navigation
fix(attachments): normalize attachment names to Unicode NFC - #9388
Merged
Merged
Conversation
github-project-automation
Bot
moved this to 馃Л Planning evaluation (don't pick)
in 馃摑 Productivity team
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Files uploaded from macOS in Chrome or Firefox have NFD names, while the filecache, and therefore the attachment list, stores names in NFC. The upload response returned the raw NFD name, so the editor inserted an NFD `src`. AttachmentResolver compared names exactly, found no matching attachment and fell back to loading the file as an image, which failed. Normalize uploaded names to NFC before saving them, and compare names in NFC in AttachmentResolver so that documents that already contain NFD srcs resolve as well. Fixes: #7873 Refs: nextcloud/server#65514 Refs: nextcloud/collectives#2327 Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
mejo-
force-pushed
the
fix/normalize_nfd_attachment_names
branch
from
October 15, 2026 06:26
2ef66fa to
2c88e49
Compare
mejo-
moved this from 馃Л Planning evaluation (don't pick)
to 馃憖 In review
in 馃摑 Productivity team
samin-z
approved these changes
Oct 15, 2026
github-project-automation
Bot
moved this from 馃憖 In review
to 鈽戯笍 Done
in 馃摑 Productivity team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files uploaded from macOS in Chrome or Firefox have NFD names, while the filecache, and therefore the attachment list, stores names in NFC. The upload response returned the raw NFD name, so the editor inserted an NFD
src. AttachmentResolver compared names exactly, found no matching attachment and fell back to loading the file as an image, which failed.Normalize uploaded names to NFC before saving them, and compare names in NFC in AttachmentResolver so that documents that already contain NFD srcs resolve as well.
Fixes: #7873
Refs: nextcloud/server#65514
Fixes: nextcloud/collectives#2327
Assisted-by: ClaudeCode:claude-opus-5-5
馃弫 Checklist
npm run lint/npm run stylelint/composer run cs:check)馃 AI (if applicable)