Repository navigation
fix(attachments): rewrite attachment file ids when copying folders - #9387
Merged
Merged
Conversation
When a folder with Markdown files is copied, the attachment folders are renamed and the relative `.attachments.<id>/` links are updated, but `/f/<fileId>` links (e.g. embedded whiteboards) kept pointing at the attachments of the source file. Users without access to the source then saw broken attachments in the copy. Map source attachments to their copies by file name and rewrite the file ids, as is already done when copying a single file. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
github-project-automation
Bot
moved this to 馃Л Planning evaluation (don't pick)
in 馃摑 Productivity team
mejo-
moved this from 馃Л Planning evaluation (don't pick)
to 馃憖 In review
in 馃摑 Productivity team
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
benjaminfrueh
approved these changes
Oct 15, 2026
github-project-automation
Bot
moved this from 馃憖 In review
to 鈽戯笍 Done
in 馃摑 Productivity team
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a folder with Markdown files is copied, the attachment folders are renamed and the relative
.attachments.<id>/links are updated, but/f/<fileId>links (e.g. embedded whiteboards) kept pointing at the attachments of the source file. Users without access to the source then saw broken attachments in the copy.Map source attachments to their copies by file name and rewrite the file ids, as is already done when copying a single file.
Fixes a bug mentioned in nextcloud/collectives#2540.
Assisted-by: ClaudeCode:claude-opus-5-5
馃弫 Checklist
npm run lint/npm run stylelint/composer run cs:check)馃 AI (if applicable)