Repository navigation
[stable35] tables: typescript and heading cell fixes - #9384
Merged
Merged
Conversation
Assisted-by: ClaudeCode:claude-opus-5.5 Signed-off-by: Jonas <jonas@freesources.org>
Table cells are serialized one by one with `serializer.serialize()`, which renders the children of the node it is given. Body cells hold paragraphs, which render their inline content with marks. Header cells hold inline content directly, so their text nodes were rendered without marks. Bold, italic, code and links in table headers were dropped when the document was saved. Serialize header cells through their own `toMarkdown()`, which renders the inline content with marks. It skips escaping of block syntax at the start of the line (e.g. `#`), because header cells are parsed as inline content. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5.5
Markdown table headers cannot span multiple lines, but pasting multi-line text into a header cell inserted hard breaks. These were saved as a multi-line header row. When the document was loaded again, the header's paragraph did not fit the inline-only header cell, so the parser put the rest of the table into a new cell. The nested-table filter then rejected the whole document, and it stayed empty in view mode. Flatten content pasted into a header cell to a single line: join paragraphs, list items and hard breaks with spaces, keeping marks and other inline nodes. Also unwrap paragraphs in header cells when parsing, so documents that already contain a multi-line header load again, with the lines joined. Fixes: #9297 Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5.5
Only the first pipe character per line of a cell was escaped when serializing tables, because the regular expression lacked the global flag. A cell containing `a|b|c` was saved as `a\|b|c`. On reload the unescaped pipe split the cell into an extra column. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5.5
mejo-
force-pushed
the
backport/9298/stable35
branch
from
October 14, 2026 10:31
07c626e to
6aac479
Compare
mejo-
approved these changes
Oct 14, 2026
mejo-
marked this pull request as ready for review
October 14, 2026 10:32
mejo-
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9298
Warning, This backport's changes differ from the original and might be incomplete鈿狅笍
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.