Repository navigation
fix(viewer): save edits before the viewer downloads the file - #9349
Merged
Merged
Conversation
The viewer app called the handler's downloadCallback before a download, which Text used to save edits not written yet. The viewer of Nextcloud 36 dispatches `before-download` on the handler's element instead: the wrapper hands it the editor's saveWhenDirty(), so the download waits for the save and gets the edits too. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvo忙 <14975046+skjnldsv@users.noreply.github.com>
mejo-
force-pushed
the
fix/save-before-download
branch
from
October 14, 2026 11:01
5febc7f to
ad71bb8
Compare
mejo-
marked this pull request as ready for review
October 14, 2026 11:01
mejo-
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
October 14, 2026 11:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text#9235 dropped the
downloadCallbackText gave the old viewer, so a download from the viewer on 36 misses unsaved edits. The viewer now dispatchesbefore-downloadon the handler's element (nextcloud-libraries/nextcloud-viewer#130), and the wrapper hands it the editor'ssaveWhenDirty().Draft until that is released and Text bumps to it. Covered by a unit test that mounts the wrapper as a custom element; not tried in a browser yet.
馃懢 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.