perf(cleanup): Optimize cleanup job

[Koc]

📝 Summary

This is continuation of the #8421.

Problem:

The text app cleanup background job took roughly 800 seconds per run. The loop over documents with no active session unconditionally called cleanupAttachments, even for documents that had unsaved changes and could not be reset. The same ~8,000 documents kept re-entering the cleanup loop every cron run, and cleanupAttachments is expensive because it resolves the file, reads Markdown content, scans the database, and iterates the attachment directory.

Solution:

... 🚧

Impact:
... 🚧

🏁 Checklist

• Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
• Sign-off message is added to all commits
• Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
• Documentation (README or documentation) has been updated or is not required

🤖 AI (if applicable)

• The content of this PR was partly or fully generated using AI tools
• The AI-generated content was reviewed, comprehended and tested by a human

[Koc]

@max-nextcloud @mejo- mates, please take a look on this

[mejo-]

I thought about this a bit more. The expensive task in the cleanup job is $this->attachmentService->cleanupAttachments($documentId), which runs for each document from the text_documents table without an active session each time. Since we introduced y-indexeddb, we no longer clean up text_documents on purpose.

One solution would be to only do the attachments cleanup if the last saved timestamp is newer than the last attachment cleanup run for that document. To do this, we would have to add a last_attachment_cleanup field to text_documents and then turn DocumentMapper::findAllWithNoActiveSessions() into findAllPendingAttachmentCleanup() which returns only documents with not active session and where last_saved_version_time > last_attachment_cleanup.

What do you think about this approach @Koc @max-nextcloud @blizzz?

[blizzz]

What do you think about this approach @Koc @max-nextcloud @blizzz?

Sound reasonable to me 👍

[mejo-]

Looks great now. I pushed a small typo fix.

[Koc]

@mejo- thank you, Jonas! I’m very appreciative of everything what you’re doing! 👏