Skip to content

refactor(file-detail-fragment): kotlin #17844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alperozturk96 merged 2 commits into from
Oct 21, 2026
+788 −933
Merged

refactor(file-detail-fragment): kotlin #17844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2c412c
Rename .java to .kt
alperozturk96 Oct 19, 2026
4082cc6
refactor(file-detail-fragment): kotlin
alperozturk96 Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...src/androidTest/java/com/owncloud/android/ui/fragment/FileDetailFragmentStaticServerIT.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ class FileDetailFragmentStaticServerIT : AbstractIT() {
val fragment = FileDetailFragment.newInstance(oCFile, user, 0)
sut.addFragment(fragment)
sut.supportFragmentManager.executePendingTransactions()
fragment.fileDetailActivitiesFragment.populateList(activities as List<Any>?, true)
fragment.fileDetailActivitiesFragment?.populateList(activities as List<Any>?, true)
}

val screenShotName = createName(testClassName + "_" + "showDetailsActivities", "")
Expand All @@ -174,7 +174,7 @@ class FileDetailFragmentStaticServerIT : AbstractIT() {
val fragment = FileDetailFragment.newInstance(oCFile, user, 0)
sut.addFragment(fragment)
activity.supportFragmentManager.executePendingTransactions()
fragment.fileDetailActivitiesFragment.populateList(emptyList(), true)
fragment.fileDetailActivitiesFragment?.populateList(emptyList(), true)
}

val screenShotName = createName(testClassName + "_" + "showDetailsActivitiesNone", "")
Expand All @@ -193,8 +193,8 @@ class FileDetailFragmentStaticServerIT : AbstractIT() {
val fragment = FileDetailFragment.newInstance(oCFile, user, 0)
sut.addFragment(fragment)
sut.supportFragmentManager.executePendingTransactions()
fragment.fileDetailActivitiesFragment.disableLoadingActivities()
fragment.fileDetailActivitiesFragment.setErrorContent(
fragment.fileDetailActivitiesFragment?.disableLoadingActivities()
fragment.fileDetailActivitiesFragment?.setErrorContent(
targetContext.resources.getString(R.string.file_detail_activity_error)
)
}
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2409,7 +2409,7 @@ class FileDisplayActivity :

val leftFragment = this.leftFragment
if (leftFragment is FileDetailFragment) {
leftFragment.getFileDetailActivitiesFragment().reload()
leftFragment.fileDetailActivitiesFragment?.reload()
}
} else {
SnackbarUtil.show(this, R.string.file_version_restored_error)
Expand Down
Loading
Loading