Skip to content

refactor(app): time constants - #17843

Merged
alperozturk96 merged 1 commit into
masterfrom
refactor/app-constants
Oct 20, 2026
Merged

alperozturk96 merged 1 commit into
masterfrom
refactor/app-constants

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Changes

  • Uses one central place for constants.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 added this to the Nextcloud App 35.1.0 milestone Oct 19, 2026
@alperozturk96 alperozturk96 added 3. to review ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) AI assisted labels Oct 19, 2026

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more magic numbers! 🎉

TAG,
"Success: users=$users, foldersAnalyzed=$foldersAnalyzed, filesPreserved=$filesPreserved, " +
"filesRemoved=$filesRemoved, spaceFreed=$spaceFreed bytes, runTime=${runTimeMs / MS_IN_SECOND} seconds"
"filesRemoved=$filesRemoved, spaceFreed=$spaceFreed bytes, runTime=${runTimeMs.milliseconds}"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, didn't know this

@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice2525
Correctness5252
Dodgy code161161
Experimental11
Malicious code vulnerability11
Multithreaded correctness2020
Performance2828
Security1616
Total304304

@github-actions

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 8636d2f
Version 17843
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@alperozturk96
alperozturk96 merged commit 7b9ec18 into master Oct 20, 2026
27 of 28 checks passed
@alperozturk96
alperozturk96 deleted the refactor/app-constants branch October 20, 2026 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants