Skip to content

fix: update deprecated Ansible variables and add repository handling for different versions - #24

Open
therb1 wants to merge 1 commit into
netdata:masterfrom
therb1:fix_ansible_deprecated_things
Open

therb1 wants to merge 1 commit into
netdata:masterfrom
therb1:fix_ansible_deprecated_things

Conversation

@therb1

@therb1 therb1 commented Nov 12, 2026

Copy link
Copy Markdown

I found a few warnings and fixed them.

 │ [WARNING]: Deprecation warnings can be disabled by setting `deprecation_warnings=False` in ansible.cfg.
  │ [DEPRECATION WARNING]: ansible.builtin.apt_repository has been deprecated. Use deb822_repository instead. This feature will be removed from ansible-core
  │   version 2.25.
  │ Origin: /home/max/.ansible/tmp/molecule.RzBf.default/roles/netdata/tasks/install-debian.yml:30:7
  │ 
  │ 28
  │ 29     - name: Add repository
  │ 30       ansible.builtin.apt_repository:
  │          ^ column 7
  │ [DEPRECATION WARNING]: INJECT_FACTS_AS_VARS default to `True` is deprecated, top-level facts will not be auto injected after the change. This feature will
  │   be removed from ansible-core version 2.24.
  │ Origin: /home/max/.ansible/tmp/molecule.RzBf.default/roles/netdata/tasks/install-debian.yml:32:15
  │ 
  │ 30       ansible.builtin.apt_repository:
  │ 31         filename: "netdata"
  │ 32         repo: >-
  │                  ^ column 15
  │ 
  │ Use `ansible_facts["fact_name"]` (no `ansible_` prefix) instead.

@therb1
therb1 requested a review from a team as a code owner November 12, 2026 23:56
@CLAassistant

CLAassistant commented Nov 12, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants