Repository navigation
Make Claude reset credits, Extra usage and plan dates selectable - #894
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Provider Data Stays Siloed |  |
The change adds provider-specific branching in shared TypeScript code. In apps/desktop-tauri/src/lib/usageItemVisibility.ts, projectClaudeSections matches providerId !== "claude" and `claudePlan… |
Move Claude-specific section projection and plan-date formatting into a Claude-specific module or provider-owned data transformation. Make shared UI consume provider-neutral projected data. Remove providerId comparisons to "claude" from… |
| Ui Changes Include Windows Proof |  |
The PR changes visible Windows UI. The diff changes MenuCard.tsx, UsageSection.tsx, UsageItemVisibilitySection.tsx, ProviderDetailPane.tsx, and tray-card styling. The description includes no s… |
Add screenshots or a clear proof note from a fresh Windows build to the PR description. The proof should cover the changed card, tray, compact Overview, and settings visibility controls. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title is a short imperative summary that clearly describes the main change: making Claude reset credits, Extra usage, and plan dates selectable. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Secrets Handled Safely No changed production path logs or displays cookies, session keys, API credentials, authorization headers, or subscription response bodies. The new subscription request reads the response into a parse… No Unapproved Dependencies The pull request changes no Cargo.toml or package.json files and adds or changes no npm, Yarn, or pnpm lockfile. It also does not change the pinned pnpm packageManager version. The dependency conditio…
Full details: Provider Data Stays Siloed
-
Explanation
The change adds provider-specific branching in shared TypeScript code. In
apps/desktop-tauri/src/lib/usageItemVisibility.ts,projectClaudeSectionsmatchesproviderId !== "claude"andclaudePlanDateNotematchesproviderId !== "claude"; both functions are outside the permitted Rust provider paths. SharedMenuCard.tsxandUsageSection.tsxcall these helpers for provider data. This matches the explicit cross-provider branching failure condition.Resolution
Move Claude-specific section projection and plan-date formatting into a Claude-specific module or provider-owned data transformation. Make shared UI consume provider-neutral projected data. Remove
providerIdcomparisons to"claude"fromapps/desktop-tauri/src/lib/usageItemVisibility.tsand other shared code.
Full details: Ui Changes Include Windows Proof
-
Explanation
The PR changes visible Windows UI. The diff changes
MenuCard.tsx,UsageSection.tsx,UsageItemVisibilitySection.tsx,ProviderDetailPane.tsx, and tray-card styling. The description includes no screenshots and states that CUA proof is pending because the desktop app was not launched. The listed test and build commands do not provide a proof note from a fresh Windows build.
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
…rows # Conflicts: # CHANGELOG.md
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
On the "Provider Data Stays Siloed" pre-merge check: the section IDs and plan-date note are Claude-only by design, matching upstream steipete#4484/steipete#4324. The frontend already gates Claude-specific card behavior the same way ( On the UI-proof warning: CUA proof is pending because the workstation is in active use. It is tracked with the remaining UI-proof items. Rendering is covered by the |
1 participant
Summary
Ports upstream steipete#4484 (selectable Claude card sections) and steipete#4324 (Claude plan renewal and expiry dates).
subscription_details(two-second budget, non-fatal). It only runs when the cookie source is on and the signed-in account is a member of the organization. The card shows "Renews: …", or "Plan expires: …" when there is no renewal date, under the quota rows. Calendar-only dates are formatted in UTC so they stay on the right day.section:subscription,section:claude-reset-creditsandsection:claude-extra-usagefor Claude (same IDs as upstream). A hidden section the provider stops reporting stays restorable as "(unavailable)". Admin API spend is never treated as Extra usage, so hiding Extra usage never hides it.Differences from upstream:
Commands run
cargo fmt --all -- --check: cleancargo test --manifest-path rust/Cargo.toml: 4661 passed, 1 ignoredcargo test --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml: 731 passedcargo clippy -D warningson both manifests: cleanpnpm test: 135 files, 1269 tests passed;pnpm run build: okUI proof
CUA proof is pending. The workstation is in active use, so I did not launch the desktop app. Rendering is covered by
MenuCard,usageItemVisibilityandUsageItemVisibilitySectiontests.