Repository navigation
Fix time-zone flake in token activity test - #890
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-only fix.
codex_activity_leaves_the_shared_cost_coverage_alonebuilt its day window fromUtc::now().date_naive(), but the fixture and production (cost_bucket_zone().date(Utc::now())) bucket by the local zone. When the local date was ahead of UTC (for example 00:00–07:00 at UTC+7), the fixture's day fell outside the window and the test failed. CI runs in UTC, so it never hit this. The test now uses the samecost_bucket_zone()date as production.Tests
cargo test --manifest-path rust/Cargo.toml --lib token_activity12 passed.cargo clippy --manifest-path rust/Cargo.toml --all-targets -- -D warnings: clean.Summary by CodeRabbit