Skip to content

Use a Windows path for the cswap placeholder - #876

Merged
Finesssee merged 1 commit into
mainfrom
fix/claude-swap-placeholder
Oct 15, 2026
Merged

Finesssee merged 1 commit into
mainfrom
fix/claude-swap-placeholder

Conversation

@Finesssee

@Finesssee Finesssee commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The Claude account switcher (cswap) executable field in Settings showed a Unix placeholder, ~/.local/bin/cswap. It now shows ~\.local\bin\cswap.exe in all 10 locales, matching how the path looks on Windows. The runner already expands both ~/ and ~\, so behavior is unchanged; only the hint text differs.

Upstream reference: CodexBar v0.74.0 (cswap placeholder).

Commands run

  • cargo test --manifest-path rust/Cargo.toml locale (24 passed)

UI proof

Text-only change to a placeholder string in the .ftl files; no layout or control changes. CUA capture was skipped for this one-string change. The locale tests confirm every bundle still parses and keeps the key.

Summary by CodeRabbit

  • Improvements
    • Updated the Claude account switcher’s example executable path to use Windows-style separators and the .exe extension across supported languages.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: nesszer/Win-CodexBar/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d6f91baa-2d6a-425a-8538-db84b661aa2e
📥 Commits

Reviewing files that changed from the base of the PR and between c80a3b6 and 33de357.

📒 Files selected for processing: 11
  • CHANGELOG.md
  • rust/src/locale/en-US.ftl
  • rust/src/locale/es-MX.ftl
  • rust/src/locale/ja-JP.ftl
  • rust/src/locale/ko-KR.ftl
  • rust/src/locale/pt-BR.ftl
  • rust/src/locale/ru-RU.ftl
  • rust/src/locale/tr-TR.ftl
  • rust/src/locale/uk-UA.ftl
  • rust/src/locale/zh-CN.ftl
  • rust/src/locale/zh-TW.ftl

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The changelog and ten locale files update the Claude Swap executable path placeholder to use Windows-style path separators. Most locale examples include the .exe extension.

Changes: Executable path placeholder

Layer / File(s) Summary
Update placeholder paths
CHANGELOG.md, rust/src/locale/*.ftl
The changelog and locale files replace Unix-style placeholder examples with Windows-style paths. Most locale examples include .exe.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: pasharm

Merge Risk: ⚪ Minimal · up to 33de3

The Windows executable-path placeholders are consistent with the resolver behavior shown, and no concrete merge-blocking risk remains.

Pre-merge checks: Passed 7 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Ui Changes Include Windows Proof Warning The PR changes the visible Settings placeholder: ClaudeSwapPathField.tsx passes ClaudeSwapExecutablePathPlaceholder to the input, and the PR changes that value in 10 locale files to `~\.local\bin\… Add screenshots of the changed Settings field from a fresh Windows build, or add a clear proof note that verifies the field in a fresh Windows build. Keep the proof in the PR description.
Passed Passed checks: 7 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title is a short imperative summary that accurately describes the Windows path update for the cswap placeholder.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Provider Data Stays Siloed Passed PASS. The pull request changes only CHANGELOG.md and ten locale files. Each locale change replaces the static ClaudeSwapExecutablePathPlaceholder text with ~\\.local\\bin\\cswap.exe; no provider logic,…
Secrets Handled Safely Passed PASS. The pull request changes only one changelog entry and ten locale placeholder strings. The added text is the literal path ~\\.local\\bin\\cswap.exe; it contains no token, cookie, API key, OAuth cr…
No Unapproved Dependencies Passed The pull request changes only CHANGELOG.md and locale .ftl files. It does not modify Cargo.toml or package.json, add npm/yarn lockfiles, or change the pinned pnpm packageManager version.
Full details: Ui Changes Include Windows Proof

Explanation

The PR changes the visible Settings placeholder: ClaudeSwapPathField.tsx passes ClaudeSwapExecutablePathPlaceholder to the input, and the PR changes that value in 10 locale files to ~\.local\bin\cswap.exe. The description does not include screenshots or a proof note from a fresh Windows build. It states that CUA capture was skipped and reports only locale tests.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Finesssee
Finesssee merged commit 90c91f7 into main Oct 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant