Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions src/__tests__/native/variables.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,60 @@ test("VariableContextProvider", () => {
expect(component.props.style).toStrictEqual({ color: "red" });
});

test("VariableContextProvider later provides a :root variable", () => {
registerCSS(
`
:root { --my-var: red; }
.test { color: var(--my-var); }
`,
{ inlineVariables: false },
);

const child = <View testID={testID} className="test" />;

const { rerender } = render(
<VariableContextProvider value={{}}>{child}</VariableContextProvider>,
);

expect(screen.getByTestId(testID).props.style).toStrictEqual({
color: "red",
});

rerender(
<VariableContextProvider value={{ "--my-var": "blue" }}>
{child}
</VariableContextProvider>,
);

expect(screen.getByTestId(testID).props.style).toStrictEqual({
color: "blue",
});
});

test("VariableContextProvider later provides a variable with a fallback", () => {
registerCSS(`.test { color: var(--my-var, red); }`);

const child = <View testID={testID} className="test" />;

const { rerender } = render(
<VariableContextProvider value={{}}>{child}</VariableContextProvider>,
);

expect(screen.getByTestId(testID).props.style).toStrictEqual({
color: "red",
});

rerender(
<VariableContextProvider value={{ "--my-var": "blue" }}>
{child}
</VariableContextProvider>,
);

expect(screen.getByTestId(testID).props.style).toStrictEqual({
color: "blue",
});
});

test("variable overriding with classes", () => {
registerCSS(`
:root {
Expand Down
4 changes: 4 additions & 0 deletions src/native/styles/variables.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ export function varResolver(
return variableCycles.has(name) ? resolve(fallback) : value;
}

// Guard the absence too, so an ancestor that later provides the variable
// replaces the :root / fallback value.
renderGuards?.push(["v", name, undefined]);

value = resolve(get(rootVariables(name)));
if (variableCycles.has(name)) return resolve(fallback);
if (value !== undefined) {
Expand Down