Skip to content

Test overlapping TCP retransmission across sequence number wrap #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szonov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Test overlapping TCP retransmission across sequence number wrap #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/stream/tcb.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,33 @@ mod tests {
assert_eq!(tcb.consume_unordered_packets(usize::MAX), None);
}

#[test]
fn test_add_unordered_packet_keeps_straddling_tail_across_sequence_wrap() {
let mut tcb = Tcb::new(
SeqNum(3),
u16::MAX,
None,
1500,
MAX_UNACK,
READ_BUFFER_SIZE,
MAX_COUNT_FOR_DUP_ACK,
RTO,
MAX_RETRANSMIT_COUNT,
);

// MAX-2, MAX-1, MAX, 0, 1, 2 are already acknowledged; 3 and 4 are new.
tcb.add_unordered_packet(SeqNum(u32::MAX - 2), vec![10, 11, 12, 13, 14, 15, 16, 17]);
assert_eq!(tcb.consume_unordered_packets(usize::MAX), Some(vec![16, 17]));
assert_eq!(tcb.ack, SeqNum(5));
assert!(tcb.unordered_packets.is_empty());

// Repeating the segment after delivery must not duplicate its tail.
tcb.add_unordered_packet(SeqNum(u32::MAX - 2), vec![10, 11, 12, 13, 14, 15, 16, 17]);
assert_eq!(tcb.consume_unordered_packets(usize::MAX), None);
assert_eq!(tcb.ack, SeqNum(5));
assert!(tcb.unordered_packets.is_empty());
}

#[test]
fn test_add_unordered_packet_enforces_read_buffer() {
let mut tcb = Tcb::new(
Expand Down