Repository navigation
Conversation
A global install ignores package-lock.json, so caret ranges let the next release of @noble/curves, @noble/hashes, @scure/base or @ethereumjs/rlp reach users before anyone has reviewed it. Pin them to the versions already locked, and add a 7-day minimum release age for new versions (.npmrc, enforced by npm 11.14+). The package test now fails if a runtime dependency in the packed tarball uses a range. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
| @@ -0,0 +1,3 @@ | |||
| # Adopt a new dependency version only after it has been public for 7 days. | |||
| # npm 11.14+ enforces this on install/update; older npm ignores it. | |||
| min-release-age=7 | |||
There was a problem hiding this comment.
🟡 - Medium | Configure the release-age delay in minutes
npm interprets min-release-age as a number of minutes, not days. With this value, a newly published dependency can be installed after seven minutes, contrary to the comment and intended seven-day review window. Set it to 10080 to enforce seven days.
nansen-pr-reviewer summaryThe change correctly pins the direct signing dependencies and adds a changeset, but the new npm release-age policy is configured with the wrong unit. npm interprets min-release-age as minutes, so this configuration delays adoption by only seven minutes rather than seven days. Findings by Severity
Deterministic check: success — Found 1 finding(s) within acceptable thresholds Risk: 3/5 (Elevated) — raised by: dependency/lockfile change ✅ Auto-approved — Deterministic gates passed: severity thresholds met, recommendation "approve_with_comments", risk level 3/5 within threshold 3. Token usage: 69,373 input, 1,674 output, 2,296 cache read | Usage Guide Cooldown: for the next 10 minutes (counting from when this review finished), new pushes to this PR will not trigger another review — the next push after the window expires will. Need a fresh review sooner? Comment |
There was a problem hiding this comment.
✅ Auto-approved by Nansen review
Deterministic gates passed: severity thresholds met, recommendation "approve_with_comments", risk level 3/5 within threshold 3.
- The deterministic severity check passed: Found 1 finding(s) within acceptable thresholds
- Risk level 3/5 (Elevated)
- The model recommended: approve_with_comments
Approval was decided by deterministic gates, not by the model. The model's recommendation can block auto-approval but never cause it.
A global
npm install -g nansen-cliignorespackage-lock.json, so the caret ranges on@noble/curves,@noble/hashes,@scure/baseand@ethereumjs/rlplet a newly published release of a library that signs transactions and x402 payments reach users before anyone reviewed it.@noble/curves 2.4.0already pins its only dependency,@noble/hashes, exactly)..npmrcwithmin-release-age=7: npm 11.14+ refuses to resolve versions younger than 7 days oninstall/update, which is how a maintainer bumps these pins. npm 10 ignores it.package.jsonuses a version range for any runtime dependency.Testing:
npm test,npm run lint; the packed tarball lists exact versions;npm@11 ciworks with the new.npmrc; reverting one pin to^makes the package test fail.🤖 Generated with Claude Code