Skip to content

fix(app/frontend): server card text overflow, jump-in card cutoff, close button hover, french sort order mistranslation, ctrl+p opens print menu - #7630

Closed
Ceebug wants to merge 10 commits into
modrinth:mainfrom
Ceebug:main
Closed

fix(app/frontend): server card text overflow, jump-in card cutoff, close button hover, french sort order mistranslation, ctrl+p opens print menu#7630
Ceebug wants to merge 10 commits into
modrinth:mainfrom
Ceebug:main

Conversation

@Ceebug

@Ceebug Ceebug commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Fixes for app/frontend:

@Ceebug
Fix server card overflow on long messages and small screens
fb5015c 
Long server status messages could overflow into other card content, while the home grid could extend past the container on smaller viewports.

Add min-w-0 and truncate to prevent long status text from overlapping other content, and update the grid sizing so it can shrink below 670px when needed.
@github-actions

github-actions Bot commented Sep 20, 2026 •
edited by Prospector
Loading

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

  • Fixed close button not having a red background on hover.
  • Fixed "Jump in" cards overflowing when the window is small.

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@Ceebug Ceebug changed the title fix(app/frontend): prevent server card overflow on long messages and small screens fix(app/frontend): prevent server card overflow on long messages and small screens, fix close button not having a red background on hover Sep 20, 2026
@shihyeon shihyeon mentioned this pull request Sep 20, 2026
Open
3 tasks
@Ceebug Ceebug changed the title fix(app/frontend): prevent server card overflow on long messages and small screens, fix close button not having a red background on hover fix(app/frontend): server card text overflow, jump-in card cutoff, close button hover Sep 20, 2026
@Prospector

Prospector commented Sep 21, 2026

Copy link
Copy Markdown
Member

@Mergifyio queue

@mergify

mergify Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Merge Queue Status

  • 🟠 Waiting for queue conditions
  • ⏳ Enter queue
  • ⏳ Run checks
  • ⏳ Merge
Waiting for
  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • check-neutral = Lint and Test
    • check-skipped = Lint and Test
    • check-success = Lint and Test
All conditions
  • -closed [📌 queue requirement]
  • any of [🔀 queue conditions]:
    • all of [📌 queue conditions of queue rule default]:
      • any of [🛡 GitHub branch protection]:
        • check-neutral = Lint and Test
        • check-skipped = Lint and Test
        • check-success = Lint and Test
      • github-review-approved [🛡 GitHub branch protection]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of [📌 queue -> configuration change requirements]:
    • -mergify-configuration-changed
    • check-success = @mergify/Configuration changed
    • check-success = @mergify/Configuration has been deleted
  • any of [📌 queue requirement]:
    • check-neutral = @mergify/Mergify Merge Protections
    • check-skipped = @mergify/Mergify Merge Protections
    • check-success = @mergify/Mergify Merge Protections

@Prospector

Prospector commented Sep 21, 2026

Copy link
Copy Markdown
Member

@Mergifyio rebase

@mergify

mergify Bot commented Sep 21, 2026

Copy link
Copy Markdown

rebase

❌ This pull request comes from a fork and cannot be rebased

Details

GitHub refuses an OAuth token on its rebase API for a fork, so rebasing one means impersonating a GitHub user to force-push the contributor's branch. Mergify does not do that.

Use the update action or the @mergifyio update command instead: it brings the pull request up to date by merging the base branch into it, and needs no impersonation. It only has something to do when the pull request is behind its base branch, so if what the branch needs is a linear history, its author has to rebase it themselves.

@Ceebug

Ceebug commented Sep 22, 2026

Copy link
Copy Markdown
Author

work! WORK!!!

@Ceebug

Ceebug commented Sep 22, 2026

Copy link
Copy Markdown
Author

NOOO! IT FAILED!!!
ok im fixing it

@Ceebug

Ceebug commented Sep 22, 2026

Copy link
Copy Markdown
Author

ok i think that will work

@Ceebug Ceebug changed the title fix(app/frontend): server card text overflow, jump-in card cutoff, close button hover fix(app/frontend): server card text overflow, jump-in card cutoff, close button hover, french sort order mistranslation Sep 22, 2026
@Ceebug
Merge branch 'modrinth:main' into main
6c3fd76
@Ceebug
Fix descending sort order being 'Nom (A-Z)' in french when it should …
73458dd 
…be 'Nom (Z-A)' (modrinth#7652)

Signed-off-by: Ceebug <caseydegan@outlook.com>
@Ceebug
Fix(app): Ctrl + P keybind works in app, bringing up the printer ui (m…
553823b 
…odrinth#5821)

Added prevention for the print dialog on Ctrl+P/Cmd+P.

Signed-off-by: Ceebug <caseydegan@outlook.com>
@Ceebug Ceebug changed the title fix(app/frontend): server card text overflow, jump-in card cutoff, close button hover, french sort order mistranslation fix(app/frontend): server card text overflow, jump-in card cutoff, close button hover, french sort order mistranslation, ctrl+p opens print window Sep 22, 2026
@Ceebug

Ceebug commented Sep 22, 2026

Copy link
Copy Markdown
Author

@Prospector do i need to request a re-run of the Lint and Test job? or will it do it on its own? if it doesnt pls rerun it

@Ceebug Ceebug changed the title fix(app/frontend): server card text overflow, jump-in card cutoff, close button hover, french sort order mistranslation, ctrl+p opens print window fix(app/frontend): server card text overflow, jump-in card cutoff, close button hover, french sort order mistranslation, ctrl+p opens print menu Sep 22, 2026
@Prospector

Prospector commented Sep 23, 2026

Copy link
Copy Markdown
Member

don't edit translations via PR, use crowdin.

Also, please don't combine multiple things into one PR. if you do so, it means any problem with one of your fixes blocks the whole PR from being merged

@IMB11

IMB11 commented Sep 23, 2026

Copy link
Copy Markdown
Member

Hi, please break up this pull request into individual ones so we can review each fix for each issue individually.

@IMB11 IMB11 closed this Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Prospector Prospector Prospector approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ceebug @Prospector @IMB11