fix(app): BEGIN IMMEDIATE for writing transactions, un-disable connection max lifetime - #7628
Merged
Merged
Conversation
Contributor
|
Note This changelog has been baked. Any further edits will not be reflected. Pull request changelogAppAddedChangedDeprecatedRemovedFixed
SecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
fetchfern
marked this pull request as draft
September 20, 2026 00:50
IMB11
marked this pull request as ready for review
September 23, 2026 09:07
Member
|
@Mergifyio queue |
Merge Queue Status
This pull request spent 1 minute 6 seconds in the queue, with no time running CI. Waiting for any of
All conditions
ReasonHintYou were too fast! Tick the box to put this pull request back in the merge queue (same as
|
IMB11
approved these changes
Sep 23, 2026
10 tasks
☑️ The pull request has been merged manuallyDetailsThe pull request has been merged manually at 71dace7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite will immediately error with
SQLITE_BUSYif it tries to promote a read transaction to a write transaction, but a write invalidated the previously-read data.BEGIN IMMEDIATEmakes the transaction immediately acquire a write lock and wait forbusy_timeout, avoiding the deadlock entirelyAlso removes the recently-introduced
max_lifetime(None)on the pool options because there's no point in setting this, better to keep rotating connections for longer app sessions