Skip to content

fix: declare typing-extensions again, since the package imports it - #260

Merged
lesnik512 merged 1 commit into
mainfrom
fix/declare-typing-extensions
Oct 27, 2026
Merged

lesnik512 merged 1 commit into
mainfrom
fix/declare-typing-extensions

Conversation

@lesnik512

Copy link
Copy Markdown
Member

Summary

#252 removed typing-extensions from dependencies on the grounds that the package never imports it. It does: broker.py, registrator.py, publisher/usecase.py and subscriber/usecase.py all import override from it, which 3.11 needs because typing.override arrived in 3.12. Installs still work only because faststream requires typing-extensions>=4.12.0. This puts the declaration back.

The floor is 4.12.0. override itself appeared in 4.4, but the 3.11 floors leg pins each direct dependency exactly at its floor, and anything below faststream 0.7.6's own >=4.12.0 would fail to resolve.

anyio and starlette are also imported without being declared. They are left as they are: faststream and fastapi guarantee them, so declaring them would add floors to maintain for no practical gain.

Checklist

  • floors steps from _checks.yml run locally on 3.11, 3.12, 3.13 and 3.14. They resolve to typing-extensions 4.12.0, 4.12.0, 4.12.2 and 4.14.1, install with --no-build, and tests/test_unit.py plus tests/test_fake.py pass on each. The DB tests on that leg are left to CI.

@github-actions

Copy link
Copy Markdown

Benchmark gate

✅ gate passed

scenario msg/s delete/msg WALrec/msg WALB/msg fpi upd del dead_tup
consumer/w1/b10 2105 1.000 6.70 919 242 5000 5000 10000
consumer/w1/b100 2014 1.000 7.11 1154 243 5000 5000 10000
consumer/w2/b10 2724 1.000 6.71 922 242 5000 5000 10000
consumer/w2/b100 3444 1.000 7.11 1154 243 5000 5000 10000
consumer/w4/b10 2880 1.000 6.74 949 242 5000 5000 10000
consumer/w4/b100 3483 1.000 7.12 1154 243 5000 5000 10000
consumer/w1/b100/tfbs100 10838 0.010 6.11 1130 243 5000 5000 10000
consumer/w1/b100/interval1-10 2246 1.000 7.11 1154 243 5000 5000 10000
producer/w1/b100 5938 0.000 3.04 597 1 0 0 0
producer/w1/b100/ppt1 1758 0.000 4.10 679 23 0 0 0

Gated (fails the build): delete_calls + tuple counters (upd/del/ins) + the producer's insert_calls, exact; select_calls and other_calls within +2; wal_records within a 10% band; fetch_calls within 2x. msg/s, WAL bytes and total calls are informational (timing/FPI noise).

@lesnik512
lesnik512 merged commit 0717a1f into main Oct 27, 2026
15 checks passed
@lesnik512
lesnik512 deleted the fix/declare-typing-extensions branch October 27, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant