Repository navigation
fix: declare typing-extensions again, since the package imports it - #260
Merged
Merged
Conversation
Benchmark gate✅ gate passed
Gated (fails the build): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#252 removed
typing-extensionsfromdependencieson the grounds that the package never imports it. It does:broker.py,registrator.py,publisher/usecase.pyandsubscriber/usecase.pyall importoverridefrom it, which 3.11 needs becausetyping.overridearrived in 3.12. Installs still work only because faststream requirestyping-extensions>=4.12.0. This puts the declaration back.The floor is 4.12.0.
overrideitself appeared in 4.4, but the 3.11 floors leg pins each direct dependency exactly at its floor, and anything below faststream 0.7.6's own>=4.12.0would fail to resolve.anyio and starlette are also imported without being declared. They are left as they are: faststream and fastapi guarantee them, so declaring them would add floors to maintain for no practical gain.
Checklist
floorssteps from_checks.ymlrun locally on 3.11, 3.12, 3.13 and 3.14. They resolve to typing-extensions 4.12.0, 4.12.0, 4.12.2 and 4.14.1, install with--no-build, andtests/test_unit.pyplustests/test_fake.pypass on each. The DB tests on that leg are left to CI.