Skip to content

fix(server): accept empty bytes data in Audio like Image - #3657

Closed
KaiyiQuan wants to merge 1 commit into
modelcontextprotocol:mainfrom
KaiyiQuan:fix/3656-audio-empty-data
Closed

KaiyiQuan wants to merge 1 commit into
modelcontextprotocol:mainfrom
KaiyiQuan:fix/3656-audio-empty-data

Conversation

@KaiyiQuan

Copy link
Copy Markdown

Summary

Audio(data=b"") raises ValueError("Either path or data can be provided") while Image(data=b"") works. Audio.__init__ validated with not bool(path) ^ bool(data), so a falsy-but-present empty bytes payload was treated as missing.

Change

Align Audio's validation with Image's: raise only when both path is None and data is None (or both provided). Same messages as Image (Either path or data must be provided / Only one of path or data can be provided).

Verification

New tests tests/server/mcpserver/utilities/test_media_types.py: Audio(data=b""), non-empty data, path-only, and the two error paths (6 passed).

Fixes #3656

Audio.__init__ validated with `not bool(path) ^ bool(data)`, treating
`data=b""` as missing and raising ValueError, while Image accepts an empty
byte payload (`Image(data=b"")` works). Both helpers should treat only
None as absent. Align Audio's validation with Image's (None-based checks,
same error messages).

Fixes modelcontextprotocol#3656
Copilot AI balanced review requested due to automatic review settings October 8, 2026 15:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md) label Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3656.

If a maintainer assigns you to #3656, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take.

You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way.

CONTRIBUTING.md has the full reasoning, but in short:

  • We're a small team with very little capacity to review community PRs right now.
  • Many recent PRs are AI-generated with little human review, and reviewing one carefully still costs a maintainer as much time as it ever did. A well-described issue is usually more useful to us than the code.

Maintainers: reopen, remove missing-issue-link, or add bypass-issue-check to override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audio(data=b"") raises "Either path or data can be provided", while Image(data=b"") works

2 participants