Repository navigation
Conversation
Author
|
Could a maintainer approve the |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #277 by verifying detached CMS signatures with platform tooling instead of node-forge's unimplemented PKCS#7 verification method.
Changes
SignedCmson Windows and OpenSSL on macOS/Linux.unsigned,invalid, anduntrustedstatuses while preservingsignedandself-signed; verifier launch and runtime errors remain verification errors.mcpb verifyandmcpb info.Compatibility
The signature block format is unchanged, and bundles produced by the previous EOCD update order remain verifiable.
McpbSignatureInfoSchemanow includesinvalidanduntrusted; callers that exhaustively handlestatusshould handle these additional values.Verification
yarn test --runInBand --silent— 8 suites, 126 tests passedyarn lint— passedyarn build— passedgit diff --check— passedVerification was run on macOS. The Windows
SignedCmsbranch still needs Windows CI.Related work
PR #255 also addresses signature verification for #277 with a different CMS verification approach.