Repository navigation
fix(memory): verify embedding models and report recall fallback - #173
Merged
Merged
Conversation
Probe the selected model in embed --status while retaining the legacy provider availability field. Report failed query embeddings on stderr and continue recall without vector similarity, preserving JSON output and existing request counts. Cover missing and invalid models, provider failures, model overrides, stored coverage, and all recall projections with local HTTP regressions. Verified make test, the product build, and a synthetic CLI fallback/recovery smoke test.
16 of 28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When Ollama is running but the configured model is missing,
embed --statuscurrently reportsembedding_available: trueandrecallsilently loses vector similarity. Status now checks the selected model with a small synthetic embedding request; the legacyollama_availablefield retains its existing provider-availability meaning. A failed query embedding prints one actionable stderr warning while recall still returns its normal JSON results.The extra model probe is limited to the explicit status command. Normal recall keeps its existing request count. Status can load the model and may incur a provider request charge; no stored memories are sent. English and Chinese usage docs explain the distinction between model availability and stored coverage.
Why
Fixes #172. Discovery success alone does not establish that the selected model can produce a vector, even when stored embedding coverage is 100%.
Validation
make test(includinggo vet ./...) andgo build -o mnemon .pass.Release-note impact: embedding diagnostics now detect unusable selected models; failed query embeddings are visible without breaking recall JSON output.
Checklist
make test)