[taran-p]

We have decided to not move forward with DeleteTableData. Since it has not made it into any non-edge releases, I have opted to remove the constant rather than deprecate

Summary by CodeRabbit

• Policy Changes
  • Removed S3TablesDeleteTableData from the supported table actions and their condition-key mappings.
  • Removed the implicit mapping from S3TablesDeleteTableData to DeleteObject. The existing implicit mappings for table-data get and put actions remain unchanged.
  • Policies can no longer use the removed action for direct or implicit matching.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 525d194a-ba92-4ade-94e0-53b2bbaad62a

📥 Commits

Reviewing files that changed from the base of the PR and between df66803 and fc39ca3.

📒 Files selected for processing: 3

• policy/actionset.go
• policy/policy_test.go
• policy/table-action.go

💤 Files with no reviewable changes: 2

• policy/table-action.go
• policy/policy_test.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The policy package no longer declares or supports S3TablesDeleteTableDataAction. Its implicit mapping to DeleteObjectAction and the related policy tests were also removed.

Changes: DeleteTableData action removal

Layer / File(s)	Summary
Remove DeleteTableData policy support policy/table-action.go, policy/actionset.go, policy/policy_test.go	Removed the action constant, supported-action entry, and condition-key mapping. Removed its implicit DeleteObjectAction mapping and tests for direct matching, implicit matching, and non-matching cases.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: harshavardhana

Merge Risk: ⚪ Minimal · up to fc39c

The intentional action removal is complete and presents no identified merge-blocking risk.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title "fix: Remove DeleteTableData action" matches the main change. The PR removes the S3TablesDeleteTableDataAction constant from policy/table-action.go, its entry in SupportedTableActions and th…
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "fix: Remove DeleteTableData action" matches the main change. The PR removes the S3TablesDeleteTableDataAction constant from policy/table-action.go, its entry in SupportedTableActions and the condition-key map, its implicit mapping to DeleteObjectAction in policy/actionset.go, and the related tests in policy/policy_test.go. The PR objectives confirm the constant is removed rather than deprecated. The title is short, specific, and uses an accurate action name. The "fix:" prefix describes the change type, which is acceptable.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit hops past the policy gate,
Where DeleteTableData no longer waits.
The implicit path is cleared away,
And tests that checked it leave today.
The quiet rulebook turns a page.}

_{Comment @coderabbitai help to get the list of available commands.}