Skip to content

feat(website): thank merged contributors - #1561

Closed
Cedric Vidal (cedricvidal) wants to merge 7 commits into
cedricvidal-website-contribution-callsfrom
cedricvidal-website-contributors
Closed

Cedric Vidal (cedricvidal) wants to merge 7 commits into
cedricvidal-website-contribution-callsfrom
cedricvidal-website-contributors

Conversation

@cedricvidal

Copy link
Copy Markdown
Collaborator

Summary

Stacked on #1560. Review this PR after the calls-for-contributions base; its diff contains only the contributor highlight.

Adds a Thank you, contributors feature to the landing page and Community → Contribute:

  • Includes every non-bot author of a merged pull request, Microsoft and community contributors alike.
  • Shows a compact avatar wall on the landing page and a detailed card grid on the Contribute page.
  • Sorts by merged pull-request count, links each person to their merged PRs, and falls back to their initial if an avatar fails.
  • Clamps edge tooltips inside the wall, handles 0/1/few/hundreds of contributors, and pages large grids behind an accessible “Show all” action.

The scheduled publisher remains a follow-up: it must write contributors.jsonl alongside issues.jsonl on the website-data branch.

Demos

Before

N/A — new website feature.

After

Walkthrough of the calls base plus the stacked contributor wall and grid:

contribution-walkthrough.mp4

Contributor edge cases

Screenshots use mocked data with fake logins and colored placeholder avatars.

0 contributors (mobile) 1 contributor (mobile) 300, right-edge tooltip kept on screen
Empty contributor state without intro or count One contributor with singular labels The right-most avatar tooltip shifted inside the mobile wall

300 contributors on the landing wall: 23 avatars and a “+277” bubble.

Landing wall with 300 contributors

60 contributors on the Contribute page: 30 cards followed by “Show all 60 contributors.”

Contributor grid with the Show all 60 contributors button

Testing

  • cd website && pnpm test: passed, 32 tests.
  • cd website && SITE=https://microsoft.github.io BASE_PATH=/scope pnpm run build: passed, 227 pages.
  • cd website && pnpm test:a11y: passed, 88 Playwright tests.
  • Playwright contributor matrix: 0, 1, 3, 24, 25, 31, 60, and 300 contributors on 1280px desktop and 375px mobile. Verified no horizontal overflow, every hovered tooltip stays inside the wall, the empty state, singular labels, overflow bubble, grid paging, “Show all,” and focus moving to the first revealed card.

Documentation and compatibility

Checklist

  • If Portal features changed, keep CLI capabilities in sync. — N/A
  • If Portal components changed, update their Storybook stories. — N/A
  • If database changes require a migration, include up() / down() and keep it CosmosDB-compatible. — N/A
  • If dependencies changed, update the lockfile and regenerate NOTICE / NOTICE-REVIEW.txt with pnpm notice as needed. — N/A
  • Video showing the behavior before the suggested change — N/A, new feature
  • Video showing the behavior after the suggested change — walkthrough and edge screenshots above

Add data helpers and tests for the contributors.jsonl file published on the website-data branch, plus a dev sample with the current external contributors.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add a <scope-contributors> element: an avatar wall with tooltips and a
+N bubble on the landing page, and a card grid in a new Thank you
section on Community > Contribute. Avatars pop in with WAAPI, the count
pill counts up, and motion is skipped when reduced motion is preferred.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Drop the authorAssociation filter so team members are thanked too (bots
remain excluded). Refresh the dev sample from live data and update copy
and docs.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… grid paging)

- Clamp wall tooltips inside the wall so edge avatars never make narrow
  pages scroll sideways.
- Hide the intro and count pill in the empty and error states.
- Page the grid at 30 cards with a 'Show all N contributors' button that
  focuses the first new card and never hides a single card.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Move the tooltip shift math and the 'Show all' label out of the element
into pure helpers so they can be unit tested.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Extend the privacy test allowlist for the expected read-only contributor
data request added by the stacked feature.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added type: documentation Documentation additions, corrections, and improvements. language: javascript Work involving JavaScript code, tooling, or dependencies. topic: testing Test coverage, test infrastructure, and validation quality. topic: ui Portal, visual presentation, layout, and interface components. labels Oct 23, 2026
@cedricvidal

Copy link
Copy Markdown
Collaborator Author

Superseded by the corrected stack: #1456 now contains the standalone contributor highlight, and #1560 adds calls for contributions on top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

language: javascript Work involving JavaScript code, tooling, or dependencies. topic: testing Test coverage, test infrastructure, and validation quality. topic: ui Portal, visual presentation, layout, and interface components. type: documentation Documentation additions, corrections, and improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant